I see that Justin had to fix the unit test for this change. Please
when you fix code in the java stack, you are also responsible for
fixing the unit tests.
jesus
On Thu, Apr 30, 2009 at 9:27 AM, Tomas Lestach
<tlestach(a)fedoraproject.org> wrote:
java/code/src/com/redhat/rhn/frontend/servlets/PxtCookieManager.java
| 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit f7461d4d4ddc5bab68a41ccbad11078b02fc9350
Author: Tomas Lestach <tlestach(a)redhat.com>
Date: Wed Apr 29 17:37:23 2009 +0200
454876 - not setting cookie domain
- domain causes troubles,
when accessing the server within the local network (without FQDN)
diff --git a/java/code/src/com/redhat/rhn/frontend/servlets/PxtCookieManager.java
b/java/code/src/com/redhat/rhn/frontend/servlets/PxtCookieManager.java
index 3959fb8..591b3ba 100644
--- a/java/code/src/com/redhat/rhn/frontend/servlets/PxtCookieManager.java
+++ b/java/code/src/com/redhat/rhn/frontend/servlets/PxtCookieManager.java
@@ -64,7 +64,10 @@ public class PxtCookieManager {
SessionManager.generateSessionKey(pxtSessionId.toString());
Cookie pxtCookie = new Cookie(cookieName, cookieValue);
- pxtCookie.setDomain(request.getServerName());
+ // BZ #454876
+ // when not using setDomain, default "Host" will be set for the
cookie
+ // there's no need to use domain and besides that it causes trouble, when
accessing the server within the local network (without FQDN)
+ // pxtCookie.setDomain(request.getServerName());
pxtCookie.setMaxAge(timeout);
pxtCookie.setPath(DEFAULT_PATH);
pxtCookie.setSecure(Config.get().isSSLAvailable());
_______________________________________________
spacewalk-commits mailing list
spacewalk-commits(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/spacewalk-commits