Changes to 'refs/tags/spacewalk-reports-1.10.7-1'
by Tomáš Kašpárek
Tag 'spacewalk-reports-1.10.7-1' created by Tomas Kasparek <tkasparek(a)redhat.com> at 2013-06-05 08:09 +0000
Tagging package [spacewalk-reports] version [1.10.7-1] in directory [reporting/].
Changes since spacewalk-backend-1.10.43-1:
Grant Gainey (1):
Resolve upgrade-script naming collision
Tomas Kasparek (2):
745342 - display more meaningful description
Automatic commit of package [spacewalk-reports] release [1.10.7-1].
---
rel-eng/packages/spacewalk-reports | 2 +-
reporting/reports/data/custom-info | 2 +-
reporting/spacewalk-reports.spec | 5 ++++-
schema/spacewalk/upgrade/spacewalk-schema-1.9-to-spacewalk-schema-1.10/018-rhnOrgConfiguration-scap.sql | 8 --------
schema/spacewalk/upgrade/spacewalk-schema-1.9-to-spacewalk-schema-1.10/019-rhnOrgConfiguration-scap.sql | 8 ++++++++
5 files changed, 14 insertions(+), 11 deletions(-)
---
10 years, 10 months
rel-eng/packages reporting/spacewalk-reports.spec
by Tomáš Kašpárek
rel-eng/packages/spacewalk-reports | 2 +-
reporting/spacewalk-reports.spec | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 52ec2baf4936f7b53962b3300e60622c591a2c34
Author: Tomas Kasparek <tkasparek(a)redhat.com>
Date: Wed Jun 5 10:09:17 2013 +0200
Automatic commit of package [spacewalk-reports] release [1.10.7-1].
diff --git a/rel-eng/packages/spacewalk-reports b/rel-eng/packages/spacewalk-reports
index beb374a..5d10b8e 100644
--- a/rel-eng/packages/spacewalk-reports
+++ b/rel-eng/packages/spacewalk-reports
@@ -1 +1 @@
-1.10.6-1 reporting/
+1.10.7-1 reporting/
diff --git a/reporting/spacewalk-reports.spec b/reporting/spacewalk-reports.spec
index 8710e8d..177c5c3 100644
--- a/reporting/spacewalk-reports.spec
+++ b/reporting/spacewalk-reports.spec
@@ -2,7 +2,7 @@ Name: spacewalk-reports
Summary: Script based reporting
Group: Applications/Internet
License: GPLv2
-Version: 1.10.6
+Version: 1.10.7
Release: 1%{?dist}
URL: https://fedorahosted.org/spacewalk
Source0: https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz
@@ -43,6 +43,9 @@ rm -rf $RPM_BUILD_ROOT
%doc COPYING
%changelog
+* Wed Jun 05 2013 Tomas Kasparek <tkasparek(a)redhat.com> 1.10.7-1
+- 745342 - display more meaningful description
+
* Fri May 24 2013 Stephen Herr <sherr(a)redhat.com> 1.10.6-1
- Report for host-guest mappings for splice integration
- Reports to support enhanced reporting
10 years, 10 months
reporting/reports
by Tomáš Kašpárek
reporting/reports/data/custom-info | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 680405d152a2c21545c21fd45ec2214888e8e7c7
Author: Tomas Kasparek <tkasparek(a)redhat.com>
Date: Wed Jun 5 10:03:12 2013 +0200
745342 - display more meaningful description
diff --git a/reporting/reports/data/custom-info b/reporting/reports/data/custom-info
index 2ccdf00..0c1d6ad 100644
--- a/reporting/reports/data/custom-info
+++ b/reporting/reports/data/custom-info
@@ -5,7 +5,7 @@ synopsis:
description:
- Display custom for all systems in spacewalk with any custom info associated
+ Display custom info for all systems in Spacewalk with any custom info associated
columns:
10 years, 10 months
schema/spacewalk
by Grant Gainey
schema/spacewalk/upgrade/spacewalk-schema-1.9-to-spacewalk-schema-1.10/018-rhnOrgConfiguration-scap.sql | 8 --------
schema/spacewalk/upgrade/spacewalk-schema-1.9-to-spacewalk-schema-1.10/019-rhnOrgConfiguration-scap.sql | 8 ++++++++
2 files changed, 8 insertions(+), 8 deletions(-)
New commits:
commit c66c8fd452c95f0bfc8f703f7a8ad0ba0381495c
Author: Grant Gainey <ggainey(a)redhat.com>
Date: Tue Jun 4 09:29:53 2013 -0400
Resolve upgrade-script naming collision
diff --git a/schema/spacewalk/upgrade/spacewalk-schema-1.9-to-spacewalk-schema-1.10/018-rhnOrgConfiguration-scap.sql b/schema/spacewalk/upgrade/spacewalk-schema-1.9-to-spacewalk-schema-1.10/018-rhnOrgConfiguration-scap.sql
deleted file mode 100644
index 02d1ae7..0000000
--- a/schema/spacewalk/upgrade/spacewalk-schema-1.9-to-spacewalk-schema-1.10/018-rhnOrgConfiguration-scap.sql
+++ /dev/null
@@ -1,8 +0,0 @@
-alter table rhnOrgConfiguration
- add scapfile_upload_enabled
- char(1) default ('N') not null
- constraint rhn_org_conf_scap_upload_chk check (scapfile_upload_enabled in ('Y', 'N'));
-alter table rhnOrgConfiguration
- add scap_file_sizelimit
- number default(2097152) not null
- constraint rhn_org_conf_scap_szlmt_chk check (scap_file_sizelimit >= 0);
diff --git a/schema/spacewalk/upgrade/spacewalk-schema-1.9-to-spacewalk-schema-1.10/019-rhnOrgConfiguration-scap.sql b/schema/spacewalk/upgrade/spacewalk-schema-1.9-to-spacewalk-schema-1.10/019-rhnOrgConfiguration-scap.sql
new file mode 100644
index 0000000..02d1ae7
--- /dev/null
+++ b/schema/spacewalk/upgrade/spacewalk-schema-1.9-to-spacewalk-schema-1.10/019-rhnOrgConfiguration-scap.sql
@@ -0,0 +1,8 @@
+alter table rhnOrgConfiguration
+ add scapfile_upload_enabled
+ char(1) default ('N') not null
+ constraint rhn_org_conf_scap_upload_chk check (scapfile_upload_enabled in ('Y', 'N'));
+alter table rhnOrgConfiguration
+ add scap_file_sizelimit
+ number default(2097152) not null
+ constraint rhn_org_conf_scap_szlmt_chk check (scap_file_sizelimit >= 0);
10 years, 10 months
Changes to 'refs/tags/spacewalk-backend-1.10.43-1'
by Michael Mraka
Tag 'spacewalk-backend-1.10.43-1' created by Michael Mraka <michael.mraka(a)redhat.com> at 2013-06-04 11:23 +0000
Tagging package [spacewalk-backend] version [1.10.43-1] in directory [backend/].
Changes since spacewalk-java-1.10.89-1:
Michael Mraka (2):
970315 - support both gz and bz2 compressed repo files
Automatic commit of package [spacewalk-backend] release [1.10.43-1].
---
backend/common/fileutils.py | 12 +++++++++++
backend/satellite_tools/repo_plugins/yum_src.py | 4 +--
backend/satellite_tools/reposync.py | 26 +++++++++---------------
backend/spacewalk-backend.spec | 5 +++-
rel-eng/packages/spacewalk-backend | 2 -
5 files changed, 29 insertions(+), 20 deletions(-)
---
10 years, 10 months
2 commits - backend/common backend/satellite_tools backend/spacewalk-backend.spec rel-eng/packages
by Michael Mraka
backend/common/fileutils.py | 12 +++++++++++
backend/satellite_tools/repo_plugins/yum_src.py | 4 +--
backend/satellite_tools/reposync.py | 26 +++++++++---------------
backend/spacewalk-backend.spec | 5 +++-
rel-eng/packages/spacewalk-backend | 2 -
5 files changed, 29 insertions(+), 20 deletions(-)
New commits:
commit e5600cebdb5083c35c01276b916f0d075d0b4fd9
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Tue Jun 4 13:23:15 2013 +0200
Automatic commit of package [spacewalk-backend] release [1.10.43-1].
diff --git a/backend/spacewalk-backend.spec b/backend/spacewalk-backend.spec
index 042a07a..0db48dc 100644
--- a/backend/spacewalk-backend.spec
+++ b/backend/spacewalk-backend.spec
@@ -12,7 +12,7 @@ Name: spacewalk-backend
Summary: Common programs needed to be installed on the Spacewalk servers/proxies
Group: Applications/Internet
License: GPLv2
-Version: 1.10.42
+Version: 1.10.43
Release: 1%{?dist}
URL: https://fedorahosted.org/spacewalk
Source0: https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz
@@ -638,6 +638,9 @@ rm -f %{rhnconf}/rhnSecret.py*
# $Id$
%changelog
+* Tue Jun 04 2013 Michael Mraka <michael.mraka(a)redhat.com> 1.10.43-1
+- 970315 - support both gz and bz2 compressed repo files
+
* Thu May 30 2013 Michael Mraka <michael.mraka(a)redhat.com> 1.10.42-1
- severity may be unknown
diff --git a/rel-eng/packages/spacewalk-backend b/rel-eng/packages/spacewalk-backend
index 82fa452..bff1f9d 100644
--- a/rel-eng/packages/spacewalk-backend
+++ b/rel-eng/packages/spacewalk-backend
@@ -1 +1 @@
-1.10.42-1 backend/
+1.10.43-1 backend/
commit e300b8cd4623122b7b28b445d6647d1832799e82
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Tue Jun 4 11:57:42 2013 +0200
970315 - support both gz and bz2 compressed repo files
diff --git a/backend/common/fileutils.py b/backend/common/fileutils.py
index 2c27e4b..290a051 100644
--- a/backend/common/fileutils.py
+++ b/backend/common/fileutils.py
@@ -15,6 +15,8 @@
import os
import sys
+import bz2
+import gzip
import pwd
import grp
import types
@@ -448,3 +450,13 @@ class payload:
def __getattr__(self, x):
return getattr(self.fileobj, x)
+
+def decompress_open(filename, mode='r'):
+ file_obj = None
+ if filename.endswith('.gz'):
+ file_obj = gzip.open(filename, mode)
+ elif filename.endswith('.bz2'):
+ file_obj = bz2.BZ2File(filename, mode)
+ else:
+ file_obj = open(filename, mode)
+ return file_obj
diff --git a/backend/satellite_tools/repo_plugins/yum_src.py b/backend/satellite_tools/repo_plugins/yum_src.py
index fef2a4e..3658289 100644
--- a/backend/satellite_tools/repo_plugins/yum_src.py
+++ b/backend/satellite_tools/repo_plugins/yum_src.py
@@ -61,14 +61,14 @@ class YumUpdateMetadata(UpdateMetadata):
if not obj:
raise UpdateNoticeException
if type(obj) in (type(''), type(u'')):
- infile = obj.endswith('.gz') and gzip.open(obj) or open(obj, 'rt')
+ infile = fileutils.decompress_open(obj)
elif isinstance(obj, YumRepository):
if obj.id not in self._repos:
self._repos.append(obj.id)
md = obj.retrieveMD(mdtype)
if not md:
raise UpdateNoticeException()
- infile = gzip.open(md)
+ infile = fileutils.decompress_open(md)
else: # obj is a file object
infile = obj
diff --git a/backend/satellite_tools/reposync.py b/backend/satellite_tools/reposync.py
index 6849d24..3e989b7 100644
--- a/backend/satellite_tools/reposync.py
+++ b/backend/satellite_tools/reposync.py
@@ -13,7 +13,6 @@
# granted to use or replicate Red Hat trademarks that are incorporated
# in this software or its documentation.
#
-import gzip
import hashlib
import os
import re
@@ -23,7 +22,7 @@ import time
from datetime import datetime
from spacewalk.server import rhnPackage, rhnSQL, rhnChannel, rhnPackageUpload
-from spacewalk.common import rhnLog, rhn_pkg
+from spacewalk.common import fileutils, rhnLog, rhn_pkg
from spacewalk.common.rhnLog import log_debug
from spacewalk.common.checksum import getFileChecksum
from spacewalk.common.rhnConfig import CFG, initCFG
@@ -175,20 +174,15 @@ class RepoSync(object):
os.makedirs(absdir)
relativepath = os.path.join(relativedir, basename)
abspath = os.path.join(absdir, basename)
- if basename.endswith('.gz'):
- # gunzip
- abspath = abspath.rstrip('.gz')
- relativepath = relativepath.rstrip('.gz')
- src = gzip.open(groupsfile)
- dst = open(abspath, "w")
- shutil.copyfileobj(src,dst)
- dst.close()
- src.close()
-
- else:
- # copy (not move) the file to get correct selinux context
- shutil.copy2(groupsfile, abspath)
-
+ for suffix in ['.gz', '.bz']:
+ if basename.endswith(suffix):
+ abspath = abspath.rstrip(suffix)
+ relativepath = relativepath.rstrip(suffix)
+ src = fileutils.decompress_open(groupsfile)
+ dst = open(abspath, "w")
+ shutil.copyfileobj(src,dst)
+ dst.close()
+ src.close()
# update or insert
hu = rhnSQL.prepare("""update rhnChannelComps
set relative_filename = :relpath,
10 years, 10 months
Changes to 'refs/tags/spacewalk-java-1.10.89-1'
by Jan Dobes
Tag 'spacewalk-java-1.10.89-1' created by Jan Dobes <jdobes(a)redhat.com> at 2013-06-03 15:53 +0000
Tagging package [spacewalk-java] version [1.10.89-1] in directory [java/].
Changes since spacewalk-schema-1.10.42-1:
Jan Dobes (3):
junit fixes
checkstyle fix
Automatic commit of package [spacewalk-java] release [1.10.89-1].
---
java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java | 26 +++++++---
java/code/src/com/redhat/rhn/common/db/datasource/test/DataListTest.java | 16 +++++-
java/code/src/com/redhat/rhn/common/hibernate/test/TestFactoryWrapperTest.java | 2
java/spacewalk-java.spec | 8 ++-
rel-eng/packages/spacewalk-java | 2
5 files changed, 42 insertions(+), 12 deletions(-)
---
10 years, 11 months
java/spacewalk-java.spec rel-eng/packages
by Jan Dobes
java/spacewalk-java.spec | 8 +++++++-
rel-eng/packages/spacewalk-java | 2 +-
2 files changed, 8 insertions(+), 2 deletions(-)
New commits:
commit 23fccd7bba2e2cd40ae833365d6038276c86fe6a
Author: Jan Dobes <jdobes(a)redhat.com>
Date: Mon Jun 3 17:53:44 2013 +0200
Automatic commit of package [spacewalk-java] release [1.10.89-1].
diff --git a/java/spacewalk-java.spec b/java/spacewalk-java.spec
index e9688ba..ac6d3ba 100644
--- a/java/spacewalk-java.spec
+++ b/java/spacewalk-java.spec
@@ -28,7 +28,7 @@ Name: spacewalk-java
Summary: Spacewalk Java site packages
Group: Applications/Internet
License: GPLv2
-Version: 1.10.88
+Version: 1.10.89
Release: 1%{?dist}
URL: https://fedorahosted.org/spacewalk
Source0: https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz
@@ -751,6 +751,12 @@ fi
%{jardir}/postgresql-jdbc.jar
%changelog
+* Mon Jun 03 2013 Jan Dobes 1.10.89-1
+- checkstyle fix
+- junit fixes
+- fix more checkstyle issues in the java-create-page.pl
+- minor changes to java-create-page.pl
+
* Thu May 30 2013 Tomas Lestach <tlestach(a)redhat.com> 1.10.88-1
- 855845 - escaping system name for
/rhn/channel/ssm/ChildSubscriptionsConfirm.do
diff --git a/rel-eng/packages/spacewalk-java b/rel-eng/packages/spacewalk-java
index c8eda21..f1829ac 100644
--- a/rel-eng/packages/spacewalk-java
+++ b/rel-eng/packages/spacewalk-java
@@ -1 +1 @@
-1.10.88-1 java/
+1.10.89-1 java/
10 years, 11 months
java/code
by Jan Dobes
java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit f783c4f4127ff966c07e0b1fca454bc8d86022b5
Author: Jan Dobes <jdobes(a)redhat.com>
Date: Mon Jun 3 16:54:36 2013 +0200
checkstyle fix
diff --git a/java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java b/java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java
index 893a974..1a04cf7 100644
--- a/java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java
+++ b/java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java
@@ -140,7 +140,8 @@ public class AdvDataSourceTest extends RhnBaseTestCase {
assertTrue(!obj.getClass().getName().equals("java.util.Map"));
//Try over-riding and getting a Map back
- SelectMode m2 = ModeFactory.getMode("test_queries", "withClass" + db_sufix, Map.class);
+ SelectMode m2 = ModeFactory.getMode("test_queries",
+ "withClass" + db_sufix, Map.class);
dr = m2.execute(params);
assertNotNull(dr);
assertTrue(dr.size() > 1);
@@ -149,7 +150,8 @@ public class AdvDataSourceTest extends RhnBaseTestCase {
assertEquals("java.util.HashMap", obj.getClass().getName());
//Try over-riding with something incompatible
- SelectMode m3 = ModeFactory.getMode("test_queries", "withClass" + db_sufix, Set.class);
+ SelectMode m3 = ModeFactory.getMode("test_queries",
+ "withClass" + db_sufix, Set.class);
try {
dr = m3.execute(params);
fail();
10 years, 11 months
java/code
by Jan Dobes
java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java | 24 +++++++---
java/code/src/com/redhat/rhn/common/db/datasource/test/DataListTest.java | 16 +++++-
java/code/src/com/redhat/rhn/common/hibernate/test/TestFactoryWrapperTest.java | 2
3 files changed, 32 insertions(+), 10 deletions(-)
New commits:
commit 9f7e391ca9ac3fc92eca41a82aec874e43edd6e9
Author: Jan Dobes <jdobes(a)redhat.com>
Date: Mon Jun 3 16:51:13 2013 +0200
junit fixes
diff --git a/java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java b/java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java
index 6cc2cae..893a974 100644
--- a/java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java
+++ b/java/code/src/com/redhat/rhn/common/db/datasource/test/AdvDataSourceTest.java
@@ -53,9 +53,19 @@ import junit.framework.TestSuite;
public class AdvDataSourceTest extends RhnBaseTestCase {
private static Logger log = Logger.getLogger(AdvDataSourceTest.class);
- private Random random = new Random();
+ private final Random random = new Random();
+ private String db_sufix;
+ private String db_user;
public AdvDataSourceTest(String name) {
super(name);
+ if (ConfigDefaults.get().isOracle()) {
+ db_sufix = "_or";
+ db_user = "SPACEUSER";
+ }
+ else {
+ db_sufix = "_pg";
+ db_user = "spaceuser";
+ }
}
private void lookup(String foobar, int id, int size) {
@@ -97,7 +107,7 @@ public class AdvDataSourceTest extends RhnBaseTestCase {
public void testMaxRows() {
if (ConfigDefaults.get().isOracle()) {
- SelectMode m = ModeFactory.getMode("test_queries", "withClass");
+ SelectMode m = ModeFactory.getMode("test_queries", "withClass" + db_sufix);
try {
m.setMaxRows(-10);
fail("setMaxRows should NOT allow negative numbers.");
@@ -118,7 +128,7 @@ public class AdvDataSourceTest extends RhnBaseTestCase {
*/
public void testModes() {
if (ConfigDefaults.get().isOracle()) {
- SelectMode m = ModeFactory.getMode("test_queries", "withClass");
+ SelectMode m = ModeFactory.getMode("test_queries", "withClass" + db_sufix);
Map params = null;
DataResult dr = m.execute(params);
assertNotNull(dr);
@@ -130,7 +140,7 @@ public class AdvDataSourceTest extends RhnBaseTestCase {
assertTrue(!obj.getClass().getName().equals("java.util.Map"));
//Try over-riding and getting a Map back
- SelectMode m2 = ModeFactory.getMode("test_queries", "withClass", Map.class);
+ SelectMode m2 = ModeFactory.getMode("test_queries", "withClass" + db_sufix, Map.class);
dr = m2.execute(params);
assertNotNull(dr);
assertTrue(dr.size() > 1);
@@ -139,7 +149,7 @@ public class AdvDataSourceTest extends RhnBaseTestCase {
assertEquals("java.util.HashMap", obj.getClass().getName());
//Try over-riding with something incompatible
- SelectMode m3 = ModeFactory.getMode("test_queries", "withClass", Set.class);
+ SelectMode m3 = ModeFactory.getMode("test_queries", "withClass" + db_sufix, Set.class);
try {
dr = m3.execute(params);
fail();
@@ -149,12 +159,12 @@ public class AdvDataSourceTest extends RhnBaseTestCase {
}
//Make sure our selectMode object was a copy and not the one cached
- SelectMode m2a = ModeFactory.getMode("test_queries", "withClass");
+ SelectMode m2a = ModeFactory.getMode("test_queries", "withClass" + db_sufix);
assertFalse(m2a.getClassString().equals("java.util.Set"));
assertFalse(m2a.getClassString().equals("java.util.Map"));
//finally, make sure that by default our DataResult objects contain Maps
- SelectMode m4 = ModeFactory.getMode("test_queries", "all_tables");
+ SelectMode m4 = ModeFactory.getMode("test_queries", "all_tables" + db_sufix);
dr = m4.execute(params);
assertNotNull(dr);
assertTrue(dr.size() > 1);
diff --git a/java/code/src/com/redhat/rhn/common/db/datasource/test/DataListTest.java b/java/code/src/com/redhat/rhn/common/db/datasource/test/DataListTest.java
index c19b275..bd0e610 100644
--- a/java/code/src/com/redhat/rhn/common/db/datasource/test/DataListTest.java
+++ b/java/code/src/com/redhat/rhn/common/db/datasource/test/DataListTest.java
@@ -19,6 +19,7 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import com.redhat.rhn.common.conf.ConfigDefaults;
import com.redhat.rhn.common.db.datasource.DataList;
import com.redhat.rhn.common.db.datasource.DataResult;
import com.redhat.rhn.common.db.datasource.ModeFactory;
@@ -30,13 +31,24 @@ public class DataListTest extends RhnBaseTestCase {
private HookedSelectMode hsm;
private Map params;
private Map elabParams;
+ private String db_sufix;
+ private String db_user;
public void setUp() {
+ if (ConfigDefaults.get().isOracle()) {
+ db_sufix = "_or";
+ db_user = "SPACEUSER";
+ }
+ else {
+ db_sufix = "_pg";
+ db_user = "spaceuser";
+ }
+
hsm = new HookedSelectMode(
- ModeFactory.getMode("test_queries", "user_tables"));
+ ModeFactory.getMode("test_queries", "user_tables" + db_sufix));
params = new HashMap();
elabParams = new HashMap();
- elabParams.put("user_name", "RHN");
+ elabParams.put("user_name", db_user);
}
public void tearDown() {
diff --git a/java/code/src/com/redhat/rhn/common/hibernate/test/TestFactoryWrapperTest.java b/java/code/src/com/redhat/rhn/common/hibernate/test/TestFactoryWrapperTest.java
index 9f761bf..a615fbd 100644
--- a/java/code/src/com/redhat/rhn/common/hibernate/test/TestFactoryWrapperTest.java
+++ b/java/code/src/com/redhat/rhn/common/hibernate/test/TestFactoryWrapperTest.java
@@ -196,7 +196,7 @@ public class TestFactoryWrapperTest extends RhnBaseTestCase {
" created timestamp with local time zone" +
")");
stmt.execute("insert into persist_test (foobar, id) " +
- "values ('Blarg', persist_sequence.nextval");
+ "values ('Blarg', persist_sequence.nextval)");
stmt.execute("insert into persist_test (foobar, id) " +
"values ('duplicate', persist_sequence.nextval)");
stmt.execute("insert into persist_test (foobar, id) " +
10 years, 11 months