On Wed, Apr 13, 2022 at 07:47:23AM +0300, Alexander Bokovoy wrote:
>I think that if the Samba package config file is unmodified, the
tool should
>replace that unmodified config file with one that just has this minimal
>config pointing to the registry (along with a suitable comment). If, on the
>other hand, the config is non-default, the tool should warn and _offer_ to
>do that, noting that it will replace existing configuration (and of course,
>it should make a backup).
Please do not do that unconditionally. As I said already first time we
discussed this topic, use of the registry is not compatible with several
Samba modes and should not be done automatically. Even if user has
installed a cockpit plugin, it does not mean that configuration has to
be changed.
I'm not suggesting doing it unconditionally, but I think it should be done
with as little bothering-the-user as possible _when the samba package is
installed via the plugin._ And I'd like it to be that easy in other cases as
well. A wizard that walks people through what you're saying are possibly
complicated and dangerous steps doesn't seem like good UX for the user
profiles we've identified for Fedora Server.
If anything, this has to be driven through the Cockpit app's page
with
an additional wizard there. You are going to get a lot of subtle bugs
otherwise which are hard to diagnoze and solve. As Samba and FreeIPA
maintainer in Fedora I am one of those who will have to work with those
bugs and I do not want to tell people they broke their installations by
installing a cockpit app plugin. We already have enough problems with FAS
plugin to FreeIPA which unconditionally changes critical configuration
settings.
I agree that we should avoid a scenario where there is an existing samba
setup, and simply installing the plugin makes a gigantic change.
--
Matthew Miller
<mattdm(a)fedoraproject.org>
Fedora Project Leader