On 6/19/06, Daniel J Walsh <dwalsh(a)redhat.com> wrote:
Tim Waugh wrote:
> On Sun, 2006-06-18 at 11:13 -0700, Tom London wrote:
>
>> Printing seemed to work regardless.
>>
>> /usr/share/hplip/base/slp.py appears to import random and call
>> 'random.randint()'
>>
>
> Doesn't seem to require a cryptographically random number here. In
> fact, I'm not even sure it needs to be a freshly-random number each
> time; perhaps '1' is sufficient. It's just for a transaction ID which
> is never checked as far as I can tell.
>
> Should I patch hplip to use '1' here instead of random.randint() do you
> think?
>
>
If it is not needed, I would guess yes.
> Tim.
> */
>
I would probably 'hack' this by trying to replace this with something
simply derived from, say, the clock, since I didn't check how 'xid' is
derived, and I don't know what would happen with collisions. [Agreed
that this would be just a hack....]
tom
--
Tom London