The change:
[1]
https://git.fedorahosted.org/cgit/scap-security-guide.git/commit/?id=d2f9...
attempted to replace "logrotate_rotate_all_files" OVAL check with
"ensure_logrotate_activated" OVAL check,
but failed (to do so in all locations):
scap-security-guide]$ grep -rHn "logrotate_rotate_all_files" *
RHEL/6/input/system/logging.xml:377:<oval id="logrotate_rotate_all_files"
/>
RHEL/7/input/system/logging.xml:377:<oval id="logrotate_rotate_all_files"
/>
resulting into the following new 'make validate' / verify-input-references.py
error message to appear:
Invalid OVAL definition referenced by XCCDF Rule: ensure_logrotate_activated
Fix that by referencing the new OVAL check name in RHEL/{6,7}/input/system/logging.xml
files too.
Besides that the original RHEL/6/input/checks/ensure_logrotate_activated.xml OVAL check
was implemented just
as unknown OVAL test stub. Replace that stub definition with actual implementation based
on guide.html content,
move it to shared, and create links for RHEL/6 and RHEL/7.
The proposal has been tested on RHEL/6 & RHEL/7 - rpm package builds properly, make
validate warning
disappeared & the check seems to be working properly on both of the products.
Please review.
Thank you && Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team