On 5/12/13 11:32 PM, Jeffrey Blank wrote:
Okay. Hopefully there will not be a performance hit, if there was a
performance benefit for instantiating common OVAL objects for some tests.
And this will quiet down anybody who does not understand what
combining OVAL checks actually entails and cannot discern
informational messages from errors.
Out of curiosity, I just time'd it. Close
enough.
(before)
[root@rhel6 RHEL6]# time oscap xccdf eval --profile stig-rhel6-server
--cpe output/ssg-rhel6-cpe-dictionary.xml output/ssg-rhel6-xccdf.xml
real 1m12.599s
user 0m41.358s
sys 0m19.485s
(after)
[root@rhel6 RHEL6]# time oscap xccdf eval --profile stig-rhel6-server
--cpe output/ssg-rhel6-cpe-dictionary.xml output/ssg-rhel6-xccdf.xml
real 1m14.018s
user 0m41.959s
sys 0m18.966s
Ideally the combinechecks script would have checked on equivalence
for
every object or state with a duplicate ID, and then only warn about
those which are different. Maybe someday it will. Until then, your
aesthetic changes (and the resulting larger output file) may have an ACK.
I'm
sorry if I like pretty things ;)
Resulting larger output file?
--
Shawn Wells
Director, Innovation Programs
shawn(a)redhat.com | 443.534.0130
@shawndwells