On 7/19/13 1:07 PM, Andrew Gilmore wrote:
---
RHEL6/input/checks/service_telnetd_disabled.xml | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/RHEL6/input/checks/service_telnetd_disabled.xml
b/RHEL6/input/checks/service_telnetd_disabled.xml
index 55623fc..81a02e1 100644
--- a/RHEL6/input/checks/service_telnetd_disabled.xml
+++ b/RHEL6/input/checks/service_telnetd_disabled.xml
@@ -8,11 +8,11 @@
</affected>
<description>Disable telnet Service</description>
</metadata>
- <criteria operator="AND">
+ <criteria comment="package telnet-server removed or service telnetd is not
configured to start" operator="OR">
+ <extend_definition comment="rpm package telnet-server removed"
definition_ref="package_telnet-server_removed" />
<criterion comment="Disable telnet Service"
test_ref="test_disable_telnet_service" />
</criteria>
</definition>
-
<ind:textfilecontent54_test check="all"
check_existence="all_exist" comment="Disable Telnet Service"
id="test_disable_telnet_service" version="1">
-- 1.7.1
This check is broke. If telnet-server is installed, though the service
is not enabled, the check fails:
[shawn@rhel6 checks]$ sudo yum -y install telnet-server
[sudo] password for shawn:
.....
Installed:
telnet-server.x86_64 1:0.17-47.el6_3.1
Complete!
[shawn@rhel6 checks]$ chkconfig --list telnet
telnet off
[shawn@rhel6 checks]$ ./testcheck.py service_telnetd_disabled.xml
Evaluating with OVAL tempfile : /tmp/service_telnetd_disabledmoc0ZM.xml
Writing results to : /tmp/service_telnetd_disabledmoc0ZM.xml-results
Definition oval:scap-security-guide.testing:def:111: false
Definition oval:scap-security-guide.testing:def:108: false
Evaluation done.
The regex appears broken within service_telnetd_disabled.xml:
<ind:pattern operation="pattern
match">disable\s=\syes</ind:pattern>
I replaced it with this, and things began to work properly:
<ind:pattern operation="pattern
match">disable(.)*?(=)(
).*?yes</ind:pattern>
Could you merge the new regex with your past, perform a quick spot
check, and re-submit your patch?