Hi all,

 

Just to remind that sshd_config may have ‘Match’ blocks at the end of file. From the manual page:

     Match   Introduces a conditional block.  If all of the criteria on the

             Match line are satisfied, the keywords on the following lines

             override those set in the global section of the config file,

             until either another Match line or the end of the file.

Any fixes/checks should have this into consideration… just appending won’t work in all cases.

 

Regards

 

--

Rui Pedro Bernardino

CTE2/Tecnologias e Desenvolvimento

PT Inovação

 

From: scap-security-guide-bounces@lists.fedorahosted.org [mailto:scap-security-guide-bounces@lists.fedorahosted.org] On Behalf Of David Smith
Sent: terça-feira, 17 de Dezembro de 2013 15:20
To: scap-security-guide@lists.fedorahosted.org
Subject: Re: [PATCH] [RHEL6] Move the closing quote in sshd disable root login remediation script at the end

 

Your change makes total sense to me -- please push!

On 12/17/2013 05:08 AM, Jan Lieskovsky wrote:

 
When checking SSH remediation / fixes prior including them into Fedora,
noticed there's a slight typo in RHEL6/input/fixes/bash/sshd_disable_root_login.sh:
 
  ..
  echo "PermitRootLogin "no >> /etc/ssh/sshd_config
  ..
 
This by itself wouldn't cause the remediation to fail, but it to be more
consistent with form of other fixes, moved the closing quote at the end
(as assuming that's what was originally intended).
 
 
Thank you && Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team




_______________________________________________
scap-security-guide mailing list
scap-security-guide@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide