On 9/16/13 7:45 AM, Jan Lieskovsky wrote:
Hello guys,

  while this got inspired by another email from this list

  (was [PATCH 1/8] Add Makefile, main README, and scap-security-guide.spec
   file, that will be used for building Fedora scap-security-guide (source)
   RPM package.)

  decided to dedicate an own thread for this topic, since it deserves it
  (pretty wide by itself).

Attached are (run on Red Hat Enterprise Linux 6) rpmlint results [R] for main
scap-security-guide.spec file, and also for both of RHEL6 / JBossEAP5 *.src.rpm, and *.rpm
packages, generated from SSG repository content.

While some of the issues are easy to fix (to mention some examples:
* scap-security-guide.src: W: summary-ended-with-dot C Security guidance and baselines in SCAP formats. 
* scap-security-guide.src:20: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 20),
* scap-security-guide.src: W: non-standard-group Testing),
* script-without-shebang /usr/share/xml/scap/ssg/policytables/table-rhel6-nistrefs.html
* ..)

[and i can make a patch proposal for these once we have agreed us on the points below],

there are also cases, where I am not sure how the fix should look like (so decided
to write a post about this prior proposing a patch).

The two cases i am not completely sure how they should be resolved (comments welcome)
are as follows:

#1: (from the *.src.rpm / *.rpm):
      scap-security-guide.src: W: invalid-license Public domain
      scap-security-guide.src: W: invalid-license GPL

    The 'Public domain' one should be converted to 'Public Domain' to be recognized
    (https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Public_Domain)

    but not sure about the proper identifier for the GPL one. Suggestions / guidance welcome.

That URL lead to the overall Fedora licensing page:
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Shareware

Nothing within existing content should be GPL. I move to drop it.


#2: (from the *.spec && *.src.rpm):
      scap-security-guide.spec: E: specfile-error error: line 10: Source0:        scap-security-guide-

    rpmlint in this case is complaining about source tarball being generated and mainly referenced in *.spec
    locally (common practice in the *.spec file to reference upstream page, where source tarball can be
    downloaded from).

    Therefore i would like to check with you, if there would be a willingness to dedicate stable page
    for hosting of such a tarball and if we could use that page (once agreed upon) in the *.spec file
    subsequently?

We've registered the following, though haven't made use of them.
http://www.scapsecurityguides.{net com org info}
ssg-project.{com net org}
ssgproject.{com net org}

Additional domain name ideas welcome :) Suggestions for a better project/domain name would be most welcome!



Thank you && Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team

[R] http://fedoraproject.org/wiki/Common_Rpmlint_issues

scap-security-guide-0.1-12.el6.noarch.rpm_rpmlint_result.txt

scap-security-guide.noarch: W: summary-ended-with-dot C Security guidance and baselines in SCAP formats.
scap-security-guide.noarch: W: non-standard-group Testing
scap-security-guide.noarch: W: invalid-license Public domain
scap-security-guide.noarch: W: invalid-license GPL
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/policytables/table-rhel6-nistrefs.html
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/content/eap5-oval.xml
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/policytables/table-rhel6-cces.html
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/content/eap5-xccdf.xml
scap-security-guide.noarch: E: wrong-script-end-of-line-encoding /usr/share/xml/scap/ssg/content/eap5-xccdf.xml
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/content/eap5-cpe-dictionary.xml
scap-security-guide.noarch: E: wrong-script-end-of-line-encoding /usr/share/xml/scap/ssg/content/eap5-cpe-dictionary.xml
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/content/ssg-rhel6-cpe-oval.xml
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/policytables/table-rhel6-srgmap.html
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/policytables/table-rhel6-nistrefs-common.html
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/policytables/table-rhel6-srgmap-flat.html
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/guide/rhel6-guide.html
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/content/ssg-rhel6-xccdf.xml
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/content/ssg-rhel6-oval.xml
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/content/eap5-ocil.xml
scap-security-guide.noarch: E: wrong-script-end-of-line-encoding /usr/share/xml/scap/ssg/content/eap5-ocil.xml
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/guide/JBossEAP5_Guide.html
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/policytables/table-rhel6-srgmap-flat.xhtml
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/content/ssg-rhel6-cpe-dictionary.xml
scap-security-guide.noarch: E: script-without-shebang /usr/share/xml/scap/ssg/content/eap5-cpe-oval.xml
scap-security-guide.noarch: W: file-not-in-%lang /usr/share/man/en/man8/scap-security-guide.8.gz
1 packages and 0 specfiles checked; 20 errors, 5 warnings.

scap-security-guide-0.1-12.el6.src.rpm_rpmlint_result.txt

scap-security-guide.src: W: summary-ended-with-dot C Security guidance and baselines in SCAP formats.
scap-security-guide.src: W: non-standard-group Testing
scap-security-guide.src: W: invalid-license Public domain
scap-security-guide.src: W: invalid-license GPL
scap-security-guide.src:20: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 20)
scap-security-guide.src: W: invalid-url Source0: scap-security-guide-0.1.tar.gz
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

scap-security-guide.spec_rpmlint_result.txt

scap-security-guide.spec:6: W: non-standard-group Testing
scap-security-guide.spec:13: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13)
scap-security-guide.spec: E: specfile-error error: Recursion depth(17) greater than max(16)
scap-security-guide.spec: E: specfile-error  15<                               (empty)
scap-security-guide.spec: E: specfile-error  14<                             (empty)
scap-security-guide.spec: E: specfile-error  13<                           (empty)
scap-security-guide.spec: E: specfile-error  12<                         (empty)
scap-security-guide.spec: E: specfile-error  11<                       (empty)
scap-security-guide.spec: E: specfile-error  10<                     (empty)
scap-security-guide.spec: E: specfile-error   9<                   (empty)
scap-security-guide.spec: E: specfile-error   8<                 (empty)
scap-security-guide.spec: E: specfile-error   7<               (empty)
scap-security-guide.spec: E: specfile-error   6<             (empty)
scap-security-guide.spec: E: specfile-error   5<           (empty)
scap-security-guide.spec: E: specfile-error   4<         (empty)
scap-security-guide.spec: E: specfile-error   3<       (empty)
scap-security-guide.spec: E: specfile-error   2<     (empty)
scap-security-guide.spec: E: specfile-error   1<   (empty)
scap-security-guide.spec: E: specfile-error   0< Source0:        scap-security-guide-
scap-security-guide.spec: E: specfile-error error: line 10: Source0:        scap-security-guide-
scap-security-guide.spec: E: specfile-error error: query of specfile scap-security-guide.spec failed, can't parse
0 packages and 1 specfiles checked; 19 errors, 2 warnings.


_______________________________________________
scap-security-guide mailing list
scap-security-guide@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide


-- 
Shawn Wells
Director, Innovation Programs
shawn@redhat.com | 443.534.0130
@shawndwells