On 9/13/13 8:11 AM, David Smith wrote:
Ahh, excellent - glad to see the addition of Fedora content!
Two quick things before I can ack this patch set:
1) Have the OVAL checks been tested in Fedora 19? In the RHEL 6
content, there is a testcheck.py within /input/checks/ -- it might be
worth copying that over.
2) When copying XCCDF and OVAL from the RHEL 6 content, we should be
careful to remove the test attestation that was done under RHEL, and
re-add it with the tester's initials and date when tested under Fedora 19.
These patches are a great start! The only thing to add:
3) As CCEs are unique between operating systems, we likely will need new
for Fedora content. For now, lets strip the CCE values.