From: Igor Gnatenko ignatenko@redhat.com
Packages will do this instead.
Signed-off-by: Igor Gnatenko ignatenko@redhat.com --- rust.spec | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/rust.spec b/rust.spec index 817ea7b..0116159 100644 --- a/rust.spec +++ b/rust.spec @@ -169,14 +169,6 @@ Requires: %{name}-std-static%{?_isa} = %{version}-%{release} # https://github.com/rust-lang/rust/issues/11937 Requires: gcc
-%if 0%{?fedora} >= 26 -# Only non-bootstrap builds should require rust-rpm-macros, because that -# requires cargo, which might not exist yet. -%ifnarch %{bootstrap_arches} -Requires: rust-rpm-macros -%endif -%endif - # ALL Rust libraries are private, because they don't keep an ABI. %global _privatelibs lib.*-[[:xdigit:]]*[.]so.* %global __provides_exclude ^(%{_privatelibs})$
On Wed, May 17, 2017 at 11:44 AM, Igor Gnatenko ignatenkobrain@fedoraproject.org wrote:
From: Igor Gnatenko ignatenko@redhat.com
Packages will do this instead.
Signed-off-by: Igor Gnatenko ignatenko@redhat.com
rust.spec | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/rust.spec b/rust.spec index 817ea7b..0116159 100644 --- a/rust.spec +++ b/rust.spec @@ -169,14 +169,6 @@ Requires: %{name}-std-static%{?_isa} = %{version}-%{release} # https://github.com/rust-lang/rust/issues/11937 Requires: gcc
-%if 0%{?fedora} >= 26 -# Only non-bootstrap builds should require rust-rpm-macros, because that -# requires cargo, which might not exist yet. -%ifnarch %{bootstrap_arches} -Requires: rust-rpm-macros -%endif -%endif
# ALL Rust libraries are private, because they don't keep an ABI. %global _privatelibs lib.*-[[:xdigit:]]*[.]so.* %global __provides_exclude ^(%{_privatelibs})$ -- 2.13.0
Why not just have an empty rust-devel that requires rust and does that? That way it's simple.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
On Wed, 2017-05-17 at 11:46 -0400, Neal Gompa wrote:
On Wed, May 17, 2017 at 11:44 AM, Igor Gnatenko ignatenkobrain@fedoraproject.org wrote:
From: Igor Gnatenko ignatenko@redhat.com
Packages will do this instead.
Signed-off-by: Igor Gnatenko ignatenko@redhat.com
rust.spec | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/rust.spec b/rust.spec index 817ea7b..0116159 100644 --- a/rust.spec +++ b/rust.spec @@ -169,14 +169,6 @@ Requires: %{name}-std-static%{?_isa} = %{version}-%{release} # https://github.com/rust-lang/rust/issues/11937 Requires: gcc
-%if 0%{?fedora} >= 26 -# Only non-bootstrap builds should require rust-rpm-macros, because that -# requires cargo, which might not exist yet. -%ifnarch %{bootstrap_arches} -Requires: rust-rpm-macros -%endif -%endif
# ALL Rust libraries are private, because they don't keep an ABI. %global _privatelibs lib.*-[[:xdigit:]]*[.]so.* %global __provides_exclude ^(%{_privatelibs})$ -- 2.13.0
Why not just have an empty rust-devel that requires rust and does that? That way it's simple.
This method has 1) Bootstrapping implications (we would need to split packages to (rust|cargo)-rpm-macros 2) Most of the users will not need those generators for their usual daily live (but it brings them some number of python packages) 3) I don't want rust to depend on python packages itself (only for packaging purpose)...
- -- - -Igor Gnatenko