Hi everybody,
I'm trying to get rails_best_practices [1] gem into fedora, so I did some specfiles [2]. (Un)fortunately those needs to get reviewed and this mailing list seems to be the best place to obtain such a thing. I'd love to ask you guys/ladies for your help. I can do some review in exchange. Please note I'm a beginner.
Thank you in advance and have a nice day! - maros
[2] Review requests: https://bugzilla.redhat.com/show_bug.cgi?id=839650 https://bugzilla.redhat.com/show_bug.cgi?id=839652 https://bugzilla.redhat.com/show_bug.cgi?id=839653 https://bugzilla.redhat.com/show_bug.cgi?id=839654
[1] Already reviewed: https://bugzilla.redhat.com/show_bug.cgi?id=839649
On 09/10/2012 11:22 AM, Maros Zatko wrote:
Hi everybody,
I'm trying to get rails_best_practices [1] gem into fedora, so I did some specfiles [2]. (Un)fortunately those needs to get reviewed and this mailing list seems to be the best place to obtain such a thing. I'd love to ask you guys/ladies for your help. I can do some review in exchange. Please note I'm a beginner.
Thank you in advance and have a nice day!
- maros
[2] Review requests: https://bugzilla.redhat.com/show_bug.cgi?id=839650
Just left some additional comments based on mfojik's comments and your updated rpm.
Same as above but s/mfojtik/mscherer
See there are a few comments from the review but also noticed this was a dev dependency for the best practices gem and isn't referenced in the rubygem-rails_best_practices spec file. We probably should be running the best practices spec suite there if we can, though if slim isn't a strict dependency I'm all for focusing on the rails_best_practices gem for the time being.
As vit pointed out, already in fedora.
-Mo
ruby-sig@lists.fedoraproject.org