Ken,
Great question. I'll admit I'm drifting around without clear direction
trying to find the right files to package. My working theory is that it
should be possible to run the tests and rebuild the gem file from the files
in the gem. In that case, the Rakefile is needed.
Could I propose that if you're going to use a different version of the
Rakefile when building the package, that you specify the location of that
file using:
rake -f Rakefile.fedora
That seems to tell a more accurate story and does not risk a collision with
what the gem provides. It also seems easier to adapt to the external world
rather than change it.
I'm happy to rethink how I'm packaging the gem. I'm just explaining my
thought process so you understand why I've been doing what I've been doing.
Cheers,
-Dan
On Sun, Mar 26, 2017 at 3:13 PM, Ken Dreyer <ktdreyer(a)ktdreyer.com> wrote:
On Fri, Mar 3, 2017 at 1:36 AM, Dan Allen
<dan.j.allen(a)gmail.com> wrote:
> Until this is fixed, my gem is going to fail in rawhide because I can't
> change the already released gem. I suspect there are others that are
failing
> as well.
Dan, I've been thinking about this issue recently. It looks like
you're purposefully including Rakefile in asciidoctor.gemspec. What is
the purpose of including Rakefile there?
Thinking about the general problem of gemspec surgery in Fedora
packaging, maybe we should take the approach that we should try to
convince upstream developers to stop shipping the files that we
surgically remove in Fedora. For example:
https://github.com/cjheath/geoip/pull/67
I think this would be an easy sell for the things like .travis.yml or
.gitignore. But if if we can't convince the upstream developers to
drop particular extraneous files from their gems, then maybe we should
give up and include those files in Fedora as well.
- Ken
_______________________________________________
ruby-sig mailing list -- ruby-sig(a)lists.fedoraproject.org
To unsubscribe send an email to ruby-sig-leave(a)lists.fedoraproject.org
--
Dan Allen | @mojavelinux |
https://twitter.com/mojavelinux