Dne 13.10.2017 v 21:49 James Hogarth napsal(a):

On 4 October 2017 at 15:16, James Hogarth <james.hogarth@gmail.com> wrote:

I have a Facter 3.9.0 package I'm happy with on initial testing. I'll be writing up a F28 self contained change shortly. I've tested puppet in F26 against this and it appears to behave correctly - would appreciate more eyes on it though.

The ruby- subpackage could be noarch IMO.

And it should depend on libfacter.so (probably instead of ruby dependency) ... but this code 'require "#{facter_dir}/lib64/libfacter.so"' is rather unfortunate, because it should not load the unversioned library, since this package belongs to -devel subpackage IMO. You have it in the main package for this reason I suppose, but that is wrong IMO:

https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages

Vít