----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/227/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
Previously, when we started up we would check whether a role was in the state we expected it to be (ready-to-start or running) and start or stop it if it didn't match our expectation. This is the wrong behavior; we need to be reporting the real state and not arbitrarily altering the system. (For example, someone may have chosen to stop one of the services through systemd for a good reason).
Diffs -----
src/rolekit/server/rolebase.py 510190a5fbd66858417e9f75f73ded63e6236b85
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/227/diff/
Testing -------
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/227/ -----------------------------------------------------------
(Updated Nov. 25, 2015, 1:50 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
Previously, when we started up we would check whether a role was in the state we expected it to be (ready-to-start or running) and start or stop it if it didn't match our expectation. This is the wrong behavior; we need to be reporting the real state and not arbitrarily altering the system. (For example, someone may have chosen to stop one of the services through systemd for a good reason).
Diffs -----
src/rolekit/server/rolebase.py 510190a5fbd66858417e9f75f73ded63e6236b85
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/227/diff/
Testing -------
Thanks,
Stephen Gallagher
rolekit-commits@lists.fedorahosted.org