----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description -------
Ordinarily a builddir!=srcdir build would prevent us from having to specify most of these, but that is not practical when parts of the source tree are generated and Python insists on importing “rolekit” from either buiddir or srcdir but not both.
Diffs -----
doc/graphics/.gitignore PRE-CREATION doc/html/.gitignore PRE-CREATION doc/man/man1/.gitignore PRE-CREATION doc/man/man5/.gitignore PRE-CREATION doc/xml/.gitignore PRE-CREATION po/.gitignore 9fa4fa3d593fa2ab615e857a6b0d387a31b9b911
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/42/diff/
Testing -------
Thanks,
Miloslav Trmac
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/#review156 -----------------------------------------------------------
Is there any real value in specifying per-folder .gitignore files, or can we just capture them universally at the top-level?
- Stephen Gallagher
On July 25, 2014, 6:52 p.m., Miloslav Trmac wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/
(Updated July 25, 2014, 6:52 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Ordinarily a builddir!=srcdir build would prevent us from having to specify most of these, but that is not practical when parts of the source tree are generated and Python insists on importing “rolekit” from either buiddir or srcdir but not both.
Diffs
doc/graphics/.gitignore PRE-CREATION doc/html/.gitignore PRE-CREATION doc/man/man1/.gitignore PRE-CREATION doc/man/man5/.gitignore PRE-CREATION doc/xml/.gitignore PRE-CREATION po/.gitignore 9fa4fa3d593fa2ab615e857a6b0d387a31b9b911
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/42/diff/
Testing
Thanks,
Miloslav Trmac
On Čec. 28, 2014, 4:17 odp., Stephen Gallagher wrote:
Is there any real value in specifying per-folder .gitignore files, or can we just capture them universally at the top-level?
I suppose per-fdoler allows more abstraction from internal details of some folders, but consolidating at the top level would be just fine with me as well, and use less space and processing time. AFAICT it was already inconsistent before my patch, and my tools make it easier to add per-folder items so I did the lazy thing :) I can revise this patch to consolidate either way.
- Miloslav
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/#review156 -----------------------------------------------------------
On Čec. 25, 2014, 8:52 odp., Miloslav Trmac wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/
(Updated Čec. 25, 2014, 8:52 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Ordinarily a builddir!=srcdir build would prevent us from having to specify most of these, but that is not practical when parts of the source tree are generated and Python insists on importing “rolekit” from either buiddir or srcdir but not both.
Diffs
doc/graphics/.gitignore PRE-CREATION doc/html/.gitignore PRE-CREATION doc/man/man1/.gitignore PRE-CREATION doc/man/man5/.gitignore PRE-CREATION doc/xml/.gitignore PRE-CREATION po/.gitignore 9fa4fa3d593fa2ab615e857a6b0d387a31b9b911
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/42/diff/
Testing
Thanks,
Miloslav Trmac
On July 28, 2014, 2:17 p.m., Stephen Gallagher wrote:
Is there any real value in specifying per-folder .gitignore files, or can we just capture them universally at the top-level?
Miloslav Trmac wrote: I suppose per-fdoler allows more abstraction from internal details of some folders, but consolidating at the top level would be just fine with me as well, and use less space and processing time. AFAICT it was already inconsistent before my patch, and my tools make it easier to add per-folder items so I did the lazy thing :) I can revise this patch to consolidate either way.
Eh, the semantics of .gitignore don't really matter to me. It's purely cosmetic anyway. Ship it.
- Stephen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/#review156 -----------------------------------------------------------
On July 25, 2014, 6:52 p.m., Miloslav Trmac wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/
(Updated July 25, 2014, 6:52 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Ordinarily a builddir!=srcdir build would prevent us from having to specify most of these, but that is not practical when parts of the source tree are generated and Python insists on importing “rolekit” from either buiddir or srcdir but not both.
Diffs
doc/graphics/.gitignore PRE-CREATION doc/html/.gitignore PRE-CREATION doc/man/man1/.gitignore PRE-CREATION doc/man/man5/.gitignore PRE-CREATION doc/xml/.gitignore PRE-CREATION po/.gitignore 9fa4fa3d593fa2ab615e857a6b0d387a31b9b911
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/42/diff/
Testing
Thanks,
Miloslav Trmac
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/#review161 -----------------------------------------------------------
Ship it!
Ship It!
- Stephen Gallagher
On July 25, 2014, 6:52 p.m., Miloslav Trmac wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/
(Updated July 25, 2014, 6:52 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Ordinarily a builddir!=srcdir build would prevent us from having to specify most of these, but that is not practical when parts of the source tree are generated and Python insists on importing “rolekit” from either buiddir or srcdir but not both.
Diffs
doc/graphics/.gitignore PRE-CREATION doc/html/.gitignore PRE-CREATION doc/man/man1/.gitignore PRE-CREATION doc/man/man5/.gitignore PRE-CREATION doc/xml/.gitignore PRE-CREATION po/.gitignore 9fa4fa3d593fa2ab615e857a6b0d387a31b9b911
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/42/diff/
Testing
Thanks,
Miloslav Trmac
On Čec. 28, 2014, 4:27 odp., Stephen Gallagher wrote:
Ship It!
https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=3875bf70fc68620eadd...
- Miloslav
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/#review161 -----------------------------------------------------------
On Čec. 28, 2014, 4:44 odp., Miloslav Trmac wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/
(Updated Čec. 28, 2014, 4:44 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Ordinarily a builddir!=srcdir build would prevent us from having to specify most of these, but that is not practical when parts of the source tree are generated and Python insists on importing “rolekit” from either buiddir or srcdir but not both.
Diffs
doc/graphics/.gitignore PRE-CREATION doc/html/.gitignore PRE-CREATION doc/man/man1/.gitignore PRE-CREATION doc/man/man5/.gitignore PRE-CREATION doc/xml/.gitignore PRE-CREATION po/.gitignore 9fa4fa3d593fa2ab615e857a6b0d387a31b9b911
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/42/diff/
Testing
Thanks,
Miloslav Trmac
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/ -----------------------------------------------------------
(Updated Čec. 28, 2014, 4:44 odp.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description -------
Ordinarily a builddir!=srcdir build would prevent us from having to specify most of these, but that is not practical when parts of the source tree are generated and Python insists on importing “rolekit” from either buiddir or srcdir but not both.
Diffs -----
doc/graphics/.gitignore PRE-CREATION doc/html/.gitignore PRE-CREATION doc/man/man1/.gitignore PRE-CREATION doc/man/man5/.gitignore PRE-CREATION doc/xml/.gitignore PRE-CREATION po/.gitignore 9fa4fa3d593fa2ab615e857a6b0d387a31b9b911
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/42/diff/
Testing -------
Thanks,
Miloslav Trmac
rolekit-commits@lists.fedorahosted.org