-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/155/
-----------------------------------------------------------
(Updated March 31, 2015, 11:25 p.m.)
Status
------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
and Thomas Woerner.
Repository: rolekit
Description
-------
Previously, we could only do limited checks on those options that
were provided to the API, but this didn't allow us to check for
missing attributes or attributes whose value is dependent on
another setting, etc.
With this patch, roles will be allowed to
raise RolekitError(INVALID_VALUE)
as long as they have not yet made any changes to the systemm
Diffs
-----
src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/155/diff/
Testing
-------
Attempted to create a database role with no settings file (and therefore no database
name). The deployment failed but no invalid instance was left behind.
Thanks,
Stephen Gallagher