-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/88/#review292
-----------------------------------------------------------
Ship it!
Ship It!
- Thomas Woerner
On Oct. 10, 2014, 7:42 p.m., Stephen Gallagher wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/88/
-----------------------------------------------------------
(Updated Oct. 10, 2014, 7:42 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
This also moves the default implementation of start() and stop()
into RoleBase. It can be overridden by the roles if they need to
perform additional operations.
Diffs
-----
config/roles/domaincontroller/role.py 4074bc946e9571de18ac0ec16ffe8d0aef6983bf
config/roles/testrole/role.py 211e26819134d0ddf8031aeba2bad432e83bbfc5
src/rolekit/server/rolebase.py 7765323d0c0ab4fab5c7a0dafd8ded8ffbb891b4
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/88/diff/
Testing
-------
Thanks,
Stephen Gallagher