-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/70/
-----------------------------------------------------------
(Updated Srp. 19, 2014, 9:36 odp.)
Status
------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
Establish a _future suffix convention for functions returning futures.
Drop async_ from names of all functions within the async module as
unnecessarily redundant. To avoid confusion, document that this
module should always be used as “async.function_name” (i.e. each time
referring to the async nature of the functionality). Hence, also
replace __all__ because it is a maintenance burden, and only useful for
“from async import *”, which we actively want to break rather than
support.
Diffs
-----
src/rolekit/async.py 0a820c383d89fd6e8a6df22968cf7bae06228b14
src/rolekit/server/dbusrole.py fdf8632b9febbe0a3a358428d065d0d63dda8777
src/rolekit/server/decorators.py 6ea1ba1e5eaad99c58b8618c4386fd2ee967619c
src/rolekit/server/rolebase.py a54a3b61b107775140a944a94bedd2dd0fa4ec81
tests/async_test.py 47a54ed408657e67e797d50d7c73d9a7982bcfc3
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/70/diff/
Testing
-------
Thanks,
Miloslav Trmac