On Sept. 9, 2015, 7:32 p.m., Stephen Gallagher wrote:
> src/rolekit/server/io/rolesettings.py, lines 155-156
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/207/diff/1/?file=1023#file1...
>
> Please add a comment explaining why IOError is acceptable. I think we probably
want to have an error logged here too.
The IOError is the only error that could happen in backup. It is logged now as an error.
On Sept. 9, 2015, 7:32 p.m., Stephen Gallagher wrote:
> src/rolekit/server/io/rolesettings.py, line 149
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/207/diff/1/?file=1023#file1...
>
> Not an issue, but this should be unnecessary since a flush() is implicit in the
"with open() as f:" syntax.
I have removed the flush call.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/207/#review514
-----------------------------------------------------------
On Sept. 9, 2015, 4:26 p.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/207/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 4:26 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
New method backup, used in write and remove
Fixes:
https://github.com/libre-server/rolekit/issues/49
Diffs
-----
src/rolekit/server/io/rolesettings.py 24e8f7aacb992440404a16c7b3014c076f66ee00
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/207/diff/
Testing
-------
Thanks,
Thomas Woerner