----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/230/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
Get role state from systemd
Diffs -----
src/rolekit/config/__init__.py.in 05d9f7b2bda59cf0b4ed6e1f277880ff2092b3c7 src/rolekit/dbus_utils.py a5f5a1d5ee4f32865fca6459615ea3359f3ca11d src/rolekit/server/io/rolesettings.py c2424f1b166eb9eec5c59e3b79047cb482ca9081 src/rolekit/server/io/systemd.py b105483c7fa689a43a960ef78aa1105f7aa58b42 src/rolekit/server/rolebase.py 510190a5fbd66858417e9f75f73ded63e6236b85
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/230/diff/
Testing -------
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/230/ -----------------------------------------------------------
(Updated Nov. 12, 2015, 9:21 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Changes -------
The original patch did not properly add monitoring for newly-created roles within the same running process (it would have monitored them after shutting down and waking back up, but we need to monitor it whenever rolekit is awake)
Repository: rolekit
Description -------
Get role state from systemd
Diffs (updated) -----
src/rolekit/config/__init__.py.in 05d9f7b2bda59cf0b4ed6e1f277880ff2092b3c7 src/rolekit/dbus_utils.py a5f5a1d5ee4f32865fca6459615ea3359f3ca11d src/rolekit/server/io/rolesettings.py c2424f1b166eb9eec5c59e3b79047cb482ca9081 src/rolekit/server/io/systemd.py b105483c7fa689a43a960ef78aa1105f7aa58b42 src/rolekit/server/rolebase.py 510190a5fbd66858417e9f75f73ded63e6236b85
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/230/diff/
Testing -------
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/230/ -----------------------------------------------------------
(Updated Nov. 20, 2015, 8:24 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
Get role state from systemd
Diffs (updated) -----
src/rolectl 91ee060b7e5de618458593ec8da7f515a53931a2 src/rolekit/config/__init__.py.in 05d9f7b2bda59cf0b4ed6e1f277880ff2092b3c7 src/rolekit/dbus_utils.py a5f5a1d5ee4f32865fca6459615ea3359f3ca11d src/rolekit/server/io/rolesettings.py c2424f1b166eb9eec5c59e3b79047cb482ca9081 src/rolekit/server/io/systemd.py b105483c7fa689a43a960ef78aa1105f7aa58b42 src/rolekit/server/rolebase.py 510190a5fbd66858417e9f75f73ded63e6236b85
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/230/diff/
Testing -------
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/230/ -----------------------------------------------------------
(Updated Nov. 20, 2015, 8:50 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Changes -------
Changed the deferred processing to explicitly *remove* the state from the JSON rather than setting it to NASCENT. Testing showed that this ended up getting passed to deploy incorrectly, which caused the deployment to fail on an unknown setting. We should probably protect against that, but this is out of scope for this patch.
Repository: rolekit
Description -------
Get role state from systemd
Diffs (updated) -----
src/rolectl 91ee060b7e5de618458593ec8da7f515a53931a2 src/rolekit/config/__init__.py.in 05d9f7b2bda59cf0b4ed6e1f277880ff2092b3c7 src/rolekit/dbus_utils.py a5f5a1d5ee4f32865fca6459615ea3359f3ca11d src/rolekit/server/io/rolesettings.py c2424f1b166eb9eec5c59e3b79047cb482ca9081 src/rolekit/server/io/systemd.py b105483c7fa689a43a960ef78aa1105f7aa58b42 src/rolekit/server/rolebase.py 510190a5fbd66858417e9f75f73ded63e6236b85
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/230/diff/
Testing -------
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/230/#review563 -----------------------------------------------------------
Ship It!
- Nils Philippsen
On Nov. 20, 2015, 9:50 nachm., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/230/
(Updated Nov. 20, 2015, 9:50 nachm.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Get role state from systemd
Diffs
src/rolectl 91ee060b7e5de618458593ec8da7f515a53931a2 src/rolekit/config/__init__.py.in 05d9f7b2bda59cf0b4ed6e1f277880ff2092b3c7 src/rolekit/dbus_utils.py a5f5a1d5ee4f32865fca6459615ea3359f3ca11d src/rolekit/server/io/rolesettings.py c2424f1b166eb9eec5c59e3b79047cb482ca9081 src/rolekit/server/io/systemd.py b105483c7fa689a43a960ef78aa1105f7aa58b42 src/rolekit/server/rolebase.py 510190a5fbd66858417e9f75f73ded63e6236b85
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/230/diff/
Testing
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/230/ -----------------------------------------------------------
(Updated Nov. 25, 2015, 1:50 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
Get role state from systemd
Diffs -----
src/rolectl 91ee060b7e5de618458593ec8da7f515a53931a2 src/rolekit/config/__init__.py.in 05d9f7b2bda59cf0b4ed6e1f277880ff2092b3c7 src/rolekit/dbus_utils.py a5f5a1d5ee4f32865fca6459615ea3359f3ca11d src/rolekit/server/io/rolesettings.py c2424f1b166eb9eec5c59e3b79047cb482ca9081 src/rolekit/server/io/systemd.py b105483c7fa689a43a960ef78aa1105f7aa58b42 src/rolekit/server/rolebase.py 510190a5fbd66858417e9f75f73ded63e6236b85
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/230/diff/
Testing -------
Thanks,
Stephen Gallagher
rolekit-commits@lists.fedorahosted.org