-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/50/#review180
-----------------------------------------------------------
config/Makefile.am
<
http://reviewboard-fedoraserver.rhcloud.com/r/50/#comment102>
This doesn‘t update uninstall; does this work with (make distcheck)?
The automake way of doing this (rather than the shell-script-way) is
systembusservicesdir = $(SYSTEM_BUS_SERVICES_DIR) # may even be
unnecessary if defined with the lowercase name by configure.ac? Unsure.
dist_systembusservices_DATA = org.fedoraproject.rolekti1.service
and nothing in EXTRA_DIST and no manual shell commands.
- Miloslav Trmac
On Čec. 28, 2014, 6:27 odp., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/50/
-----------------------------------------------------------
(Updated Čec. 28, 2014, 6:27 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
pkg-config dbus-1 --variable=system_bus_services_dir
is used in configure to get the default value of the system.
New BuildRequires for dbus-devel to get the default directory.
Diffs
-----
config/Makefile.am 97787cfadeb49bf29265026789dcc6be0b6d3a5d
config/org.fedoraproject.rolekit1.service PRE-CREATION
configure.ac 0c2622c7391c88e700aeab97d8e0af6d974dd194
rolekit.spec 479b6c5e4fc367aad9749aa3aca4b9962e25dc1a
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/50/diff/
Testing
-------
Thanks,
Thomas Woerner