This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/123/

doc/xml/rolekit.roles.xml (Diff revision 1)
124
      Steps check values of role specific properties:

s/Steps check/Steps to check/


doc/xml/rolekit.roles.xml (Diff revision 1)
128
            Check value for property prop.

Put "prop" in quotes to indicate that it's an argument.


doc/xml/rolekit.roles.xml (Diff revision 1)
143
            Return False otherwise.

Let's make this more clear (because I was confused by this myself, actually).

We return False if-and-only-if the do_check_property method was incapable of checking this property.


- Stephen Gallagher


On November 13th, 2014, 4:50 p.m. UTC, Thomas Woerner wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Thomas Woerner.

Updated Nov. 13, 2014, 4:50 p.m.

Repository: rolekit

Description

rolekit.roles.xml: Add more information to do_check_property method

Diffs

  • doc/xml/rolekit.roles.xml (58733254f97a8b80cc04501a95543e9acb923836)

View Diff