This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/178/

Ship it!

Ship It!

- Nils Philippsen


On August 26th, 2015, 2:34 nachm. CEST, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated Aug. 26, 2015, 2:34 nachm.

Repository: rolekit

Description

This is a temporary measure; this code will be going upstream into python-systemd in the near future, but for now we will carry it in rolekit.

There is one known limitation to this implementation; It does not support reading unit files with multiline values. This won't be an issue in rolekit, but it's preventing it from going upstream to python-systemd at the moment.

Testing

Testing performed manually by loading the python module and writing out some sample unit files. Also tested with the kickstart patch.

Diffs

  • src/rolekit/server/io/systemd.py (b4ef538ffcc2b3d49f5304c468ccb4e0bcb1ac61)

View Diff