----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/82/ -----------------------------------------------------------
(Updated Oct. 9, 2014, 8:04 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Changes -------
Fixes a bug with getting the instance name in domaincontroller and also initiates a daemon-reload in systemd after creating the new unit files.
Repository: rolekit
Description -------
This patch causes new systemd unit files to be generated when a role is deployed.
Target: This unit file will ensure that all dependent services are started when the role is launched.
Extension units: These units extend the existing dependent services and provide the reverse of the above: they ensure that stopping the role target stops all of the dependent processes. It also guarantees that a failure of one of these processes updates the rolekit state for the role.
Failure unit: This is a special unit that emits a DBUS message to roled if one of the dependent services has failed.
Diffs (updated) -----
config/roles/domaincontroller/role.py 4074bc946e9571de18ac0ec16ffe8d0aef6983bf configure.ac 67b01d330aa08822e87eb0c8e8f086aeef756d78 src/Makefile.am 0a4193038be7aeac2bcc017fd2552e72dd501c2a src/rolekit/config/__init__.py.in 3e71532fcb71fb34c3ae087c2d502ec1f55138f9 src/rolekit/server/io/systemd.py PRE-CREATION src/rolekit/server/rolebase.py 7765323d0c0ab4fab5c7a0dafd8ded8ffbb891b4
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/82/diff/
Testing (updated) -------
Deployed and decommissioned a domaincontroller role successfully.
Thanks,
Stephen Gallagher