This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/203/

This change has been marked as submitted.


Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated Sept. 2, 2015, 4:01 p.m.

Bugs: 43
Repository: rolekit

Description

This patch changes the default behavior of the domain controller
role. After discussions with UXD experts, it was determined that
the domain should never be auto-detected from the environment,
since it is very difficult to change later. It should always come
from some user action.

This patch changes the default domain to use the role instance name
for the domain name, as long as the instance name contains valid
characters. It also changes the behavior of the host_name option to
set the hostname to dc-<16 characters> if it is currently set to
localhost.

Fixes https://github.com/libre-server/rolekit/issues/43

Testing

Deployed multiple domain controllers with varying initial hostnames.

Diffs

  • doc/xml/rolekit.roles.domaincontroller.xml (2416c889ba0035dc6247b2eb209dbe13eb3b9708)
  • config/roles/domaincontroller/role.py (62d2bc64d6efb9c2b7e254c8d61c612f05e4c4be)

View Diff