This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/158/ |
On June 17th, 2015, 3:47 p.m. UTC, Miloslav Trmac wrote:
src/rolekit/async.py (Diff revision 2) def start_with_callbacks(generator, result_handler, error_handler):102 The requirement to yield the final return value instead of just returning
102 The requirement to yield the final return value instead of just returning
103 could go away with PEP 380 (i.e. requiring Python 3.3).
103 could go away with PEP 380 (i.e. requiring Python 3.3).
What is the specific Python 3 requirement? 3.0?
This would be a simplification worth trying I think (carefully because removing the last yield would replace a generator with an ordinary function, but hiding this difference would also be nice).
I think this sounds interesting, but I think it should probably be done outside of this specific review. Would you be willing to help with that conversion? I'll be the first to admit that I don't understand the python-futures code very well.
- Stephen
On June 17th, 2015, 3:44 p.m. UTC, Stephen Gallagher wrote:
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.
Updated June 17, 2015, 3:44 p.m.
Repository:
rolekit
Description
Testing
Diffs
|