This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/134/

config/roles/databaseserver/role.py (Diff revision 1)
def do_deploy_async(self, values, sender=None):
173
        postgresql_conf = "/var/lib/pgsql/data/postgresql.conf"
174
        shutil.copy2(postgresql_conf, "%s.old" % postgresql_conf)

Unnecessary copy

There's no reason to create this copy manually. The -i argument to sed can optionally take a suffix for creating a backup file.


config/roles/databaseserver/role.py (Diff revision 1)
def do_deploy_async(self, values, sender=None):
190
        pg_hba_conf = "/var/lib/pgsql/data/pg_hba.conf"
191
        shutil.copy2(pg_hba_conf, "%s.old" % pg_hba_conf)

Unnecessary copy

There's no reason to create this copy manually. The -i argument to sed can optionally take a suffix for creating a backup file.


- Stephen Gallagher


On February 20th, 2015, 5:06 p.m. UTC, Thomas Woerner wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Thomas Woerner.

Updated Feb. 20, 2015, 5:06 p.m.

Repository: rolekit

Description

- Creates backup copy of the files

Diffs

  • config/roles/databaseserver/role.py (a1d215118205382dec93b8b033b5246c515a4134)

View Diff