This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/

On July 14th, 2014, 1:26 p.m. UTC, Thomas Woerner wrote:

config/roles/databaseserver/role.py (Diff revision 1)
65
        super(Role, self).decommission()

Maybe it would be good to also have get_dbus_property in the roles for now with the comments to make the use of additional properties simple.

Sorry, could you give an example of what you mean? I'm not sure what properties have to do with decomission()


- Stephen


On July 14th, 2014, 11:42 a.m. UTC, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Stephen Gallagher.

Updated July 14, 2014, 11:42 a.m.

Repository: rolekit

Description

Add placeholders for Domain Controller and Database roles

Testing

Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.

Diffs

  • config/Makefile.am (88f68818c877eeadf05e3c6bccea77e6693d428c)
  • config/roles/databaseserver/role.py (PRE-CREATION)
  • config/roles/domaincontroller/role.py (PRE-CREATION)

View Diff