This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/154/

Ship it!

If instances in NASCENT or ERROR are guarnteed to not cause a failure if first_instance is set to true, this looks good. Not sure what kind of error state you'll get in if that is not the case, but I guess it will be ugly either way.


- Simo Sorce


On March 31st, 2015, 7:24 p.m. UTC, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
By Stephen Gallagher.

Updated March 31, 2015, 7:24 p.m.

Bugs: 43
Repository: rolekit

Description

An instance that failed to deploy should not count as a pre-
existing instance. This would prevent the database from being
initialized properly.

Testing

Created a first instance in error state (no database name, so nothing happened on disk). Created a second instance with correct input. Success.

Diffs

  • config/roles/databaseserver/role.py (e2133535f4d8e59b0c1c27f8d6e171f8910d4d12)

View Diff