This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/155/

Ship it!

Ship It!

- Simo Sorce


On March 31st, 2015, 7:26 p.m. UTC, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
By Stephen Gallagher.

Updated March 31, 2015, 7:26 p.m.

Repository: rolekit

Description

Previously, we could only do limited checks on those options that
were provided to the API, but this didn't allow us to check for
missing attributes or attributes whose value is dependent on
another setting, etc.

With this patch, roles will be allowed to
raise RolekitError(INVALID_VALUE)
as long as they have not yet made any changes to the systemm

Testing

Attempted to create a database role with no settings file (and therefore no database name). The deployment failed but no invalid instance was left behind.

Diffs

  • src/rolekit/server/rolebase.py (57485a31a94d3be0ca15eb9d97df7a7654d2e6fc)

View Diff