This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/220/

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Nils Philippsen.
Repository: rolekit

Description

Import specific names rather than wildcards. Remove unnecessary imports.

Testing

Successfully deployed and decommissioned databaseserver, memcache and domaincontroller.

Diffs

  • config/roles/databaseserver/role.py (7443979ba7ff87ff6a018ac8a7a0a89e2b8ad6e7)
  • config/roles/domaincontroller/role.py (899a5aa99bfd4b7311db7bb0bba5adcf1740ab86)
  • config/roles/memcache/role.py (c2d82c19e80b553fc7f2223e99a06a1b4e02355b)
  • config/roles/testrole/role.py (a592fbba02a385610bc9180bce8e7d3fb3553660)
  • doc/examples/emptyrole/role.py (d6207fbdc94f11aa0de243e51de259dd2e552a5a)
  • src/rolectl (9d8394628ea142788aef20d10a53dbdf5c092567)
  • src/roled (52c48f1e081f3228de4f0f552d8e5c24fd1aaac4)
  • src/rolekit/client.py (c90c0aaf091c1026c2341b76be05d69ebff9e200)
  • src/rolekit/server/dbusrole.py (3c0dff6a186d36711200074cd8e7530ee66ff64b)
  • src/rolekit/server/decorators.py (8a5aed76f31d35a8c22d548ebc4804e7259a6ef2)
  • src/rolekit/server/io/rolesettings.py (5b3bd595b0fb04f960c2de2c10c4882979320857)
  • src/rolekit/server/rolebase.py (ba127afd018c26d2b1b5d9ffc30e960bf2ed1116)
  • src/rolekit/server/roled.py (5dcfd99ded48db0304b752508d83bfbdcc82123d)
  • src/rolekit/server/server.py (7e400822ec238f9f9bcffd4386eaf1fcd5b8cd94)

View Diff