This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/148/

config/roles/databaseserver/role.py (Diff revision 3)
def do_deploy_async(self, values, sender=None):
173
        if 'password' not in values:

Idea: In case that the password was supplied by the user, it might be good not to save it in the settings. The roled created password needs to be saved in the settings, though.

This is good for security, but makes it inconsistent in these two cases.

What do you think?


- Thomas Woerner


On March 25th, 2015, 8:38 p.m. UTC, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
By Stephen Gallagher.

Updated March 25, 2015, 8:38 p.m.

Repository: rolekit

Description

We'll use db_owner if it's unspecified.

Diffs

  • config/roles/databaseserver/role.py (e2133535f4d8e59b0c1c27f8d6e171f8910d4d12)
  • doc/xml/rolekit.roles.databaseserver.xml (112a40c9d8fb0a268e74bc022857bef4587103e8)

View Diff