This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/197/ |
Question: are we certain that sanitization will always be synchronous? I can't think of any examples where it wouldn't be, but I do wonder if we should plan for the future, just in case.
src/rolekit/server/rolebase.py (Diff revision 1) | |||
---|---|---|---|
def apply_values(self, values): |
|||
586 | # emit property changed |
||
587 | def _emit_property_changed(self, prop, value): |
||
588 | # use value from get_dbus_property, it is already converted for dbus |
||
589 | if prop in self._DEFAULTS: |
||
590 | dbus_changed = dbus.Dictionary(signature="sv") |
||
591 | dbus_changed[prop] = self.get_dbus_property(self, prop) |
||
592 | self.PropertiesChanged(DBUS_INTERFACE_ROLE_INSTANCE, |
||
593 | dbus_changed, [ ]) |
I think this belongs in review #196 not here.
src/rolekit/server/rolebase.py (Diff revision 1) | |||
---|---|---|---|
1190 | if hasattr(self, "do_sanitize"): |
||
1191 | try: |
||
1192 | self.do_sanitize() |
||
1193 | except: |
||
1194 | raise |
||
1195 | else: |
||
1196 | self._settings.write() |
We should just call self.do_sanitize() and catch NameError exceptions.
- Stephen Gallagher
On August 26th, 2015, 2:01 p.m. UTC, Thomas Woerner wrote:
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Thomas Woerner.
Updated Aug. 26, 2015, 2:01 p.m.
Bugs:
33
Repository:
rolekit
Description
Diffs
|