This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/154/ |
On March 31st, 2015, 7:47 p.m. UTC, Simo Sorce wrote:
If instances in NASCENT or ERROR are guarnteed to not cause a failure if first_instance is set to true, this looks good. Not sure what kind of error state you'll get in if that is not the case, but I guess it will be ugly either way.
In the current implementation of the initdb, it's a slow (3-5s) no-op if it is called after the system is already initialized, but I didn't want to count on that always being true, hence skipping it if other instances already exist.
- Stephen
On March 31st, 2015, 7:24 p.m. UTC, Stephen Gallagher wrote:
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
By Stephen Gallagher.
Updated March 31, 2015, 7:24 p.m.
Bugs:
43
Repository:
rolekit
Description
Testing
Diffs
|