This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/30/ |
Not a full review at this point.
src/rolectl (Diff revision 1) | |||
---|---|---|---|
75 | raise ValueError(msg) |
Undefined variable msg
src/rolectl (Diff revision 1) | |||
---|---|---|---|
78 | def create_settings(list): |
What is “list” used for?
src/rolectl (Diff revision 1) | |||
---|---|---|---|
80 | if a.set: |
Would be cleaner with an explicitly passed parameter for “a”.
src/rolectl (Diff revision 1) | |||
---|---|---|---|
85 | settings[splits[0].strip()] = splits[1].strip() |
Can I set non-string settings?
N
- Miloslav Trmac
On červenec 22nd, 2014, 12:25 odp. CEST, Thomas Woerner wrote:
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Thomas Woerner.
Updated Čec. 22, 2014, 12:25 odp.
Repository:
rolekit
Description
Diffs
|