Review Request 5: Silence a warning about an undefined variable
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/5/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
a = undefined_variable_name
is way too obvious for static analysis tools to detect; if we want
to raise an exception, use something rarer.
This doesn’t change behavior of the test code; the log in /tmp/log
handles both NameError and ZeroDivisionError in the same way.
Eventually, we might end up just with an explicit
raise SomeExceptionType
but that’s a less realistic test code, so let’s not do it just now.
Diffs
-----
src/rolekit/logger.py 9ad2464b00daa748e87cd137b7dade2d160c9313
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/5/diff/
Testing
-------
Thanks,
Miloslav Trma?
9 years, 10 months
Review Request 2: Add placeholders for Domain Controller and Database roles
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/2/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Add placeholders for Domain Controller and Database roles
Diffs
-----
config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c
config/roles/databaseserver/role.py PRE-CREATION
config/roles/domaincontroller/role.py PRE-CREATION
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/
Testing
-------
Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.
Thanks,
Stephen Gallagher
9 years, 10 months
Review Request 310: improved testrole
by Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://fedorahosted.org/reviewboard/r/310/
-----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
- Added missing imports for dbus type conversion and possible method calls
- Dropped "backup_paths" setting from _DEFAULS
- Added own setting "myownsetting" altogether with an extended get_dbus_property method
- Added not covered "failonthis" setting to show error message in the log with get_dbus_property calls
Diffs
-----
config/roles/testrole/role.py 5a47874456eaa3a1de5793b86e96f7c01a6d641d
Diff: https://fedorahosted.org/reviewboard/r/310/diff/
Testing
-------
Thanks,
Thomas Woerner
9 years, 10 months