Review Request 81: Fix typo
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/81/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Summary (updated)
-----------------
Fix typo
Repository: rolekit
Description (updated)
-------
check_type_book() should have been check_type_bool()
Diffs (updated)
-----
config/roles/domaincontroller/role.py 955370ec2030c65931b18903dd0c2e278e8f402f
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/81/diff/
Testing (updated)
-------
Successfully deployed a domaincontroller role. Previously it would fail near the end with the error:
Error: 'Role' object has no attribute 'check_type_book'
Thanks,
Stephen Gallagher
9 years, 7 months
Review Request 69: RoleBase: Implement installFirewall, updateFirewall and uninstallFirewall
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/69/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
installFirewall uses the firewall _settings from the role: firewall and firewall_zones and stores the applied settings in _settings per zone and also for the runtime and permanant firewalld environment.
uninstallFirewall uses the fw_changes _setting from the role and removed them from the zones in runtime and permanent firewalld environment, then clears fw_changes and savet it to _settings again.
updateFirewall calls uninstallFirewall and then installFirewall
_check_property now checks ports to be valid.
Diffs
-----
src/rolekit/server/rolebase.py 783804e3f8529232b1c0327de4d87130aaca119d
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/69/diff/
Testing
-------
Thanks,
Thomas Woerner
9 years, 7 months