----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/176/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
rolectl: handle "rolectl list" without command
Diffs -----
src/rolectl 73ff76e6c0dda59690410934dbfb366f63252fc1
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/176/diff/
Testing -------
Thanks,
Nils Philippsen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/176/ -----------------------------------------------------------
(Updated Aug. 3, 2015, 5:52 nachm.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
rolectl: handle "rolectl list" without command
Diffs -----
src/rolectl 73ff76e6c0dda59690410934dbfb366f63252fc1
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/176/diff/
Testing (updated) -------
Simply called `rolectl list` without `roles` or `instances`.
Thanks,
Nils Philippsen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/176/#review452 -----------------------------------------------------------
src/rolectl (lines 208 - 211) http://reviewboard-fedoraserver.rhcloud.com/r/176/#comment259
Please check for an AttributeError exception instead of using hasattr().
- Stephen Gallagher
On Aug. 3, 2015, 3:52 p.m., Nils Philippsen wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/176/
(Updated Aug. 3, 2015, 3:52 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
rolectl: handle "rolectl list" without command
Diffs
src/rolectl 73ff76e6c0dda59690410934dbfb366f63252fc1
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/176/diff/
Testing
Simply called `rolectl list` without `roles` or `instances`.
Thanks,
Nils Philippsen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/176/ -----------------------------------------------------------
(Updated Aug. 4, 2015, 10:23 vorm.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
rolectl: handle "rolectl list" without command
Diffs (updated) -----
src/rolectl f0f575a74e6f7b8d08de9a974f71322437e020bf
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/176/diff/
Testing -------
Simply called `rolectl list` without `roles` or `instances`.
Thanks,
Nils Philippsen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/176/#review453 -----------------------------------------------------------
Ship it!
Ship It!
- Stephen Gallagher
On Aug. 4, 2015, 8:23 a.m., Nils Philippsen wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/176/
(Updated Aug. 4, 2015, 8:23 a.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
rolectl: handle "rolectl list" without command
Diffs
src/rolectl f0f575a74e6f7b8d08de9a974f71322437e020bf
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/176/diff/
Testing
Simply called `rolectl list` without `roles` or `instances`.
Thanks,
Nils Philippsen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/176/ -----------------------------------------------------------
(Updated Aug. 4, 2015, 9:29 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
rolectl: handle "rolectl list" without command
Diffs -----
src/rolectl f0f575a74e6f7b8d08de9a974f71322437e020bf
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/176/diff/
Testing -------
Simply called `rolectl list` without `roles` or `instances`.
Thanks,
Nils Philippsen
rolekit-commits@lists.fedorahosted.org