----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description -------
RoleBase: Write out error state changes, apply_values fails into error state
Diffs -----
src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/27/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/#review76 -----------------------------------------------------------
src/rolekit/server/rolebase.py http://reviewboard-fedoraserver.rhcloud.com/r/27/#comment61
Doesn’t do anything
- Miloslav Trmac
On Čec. 22, 2014, 12:24 odp., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/
(Updated Čec. 22, 2014, 12:24 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
RoleBase: Write out error state changes, apply_values fails into error state
Diffs
src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/27/diff/
Testing
Thanks,
Thomas Woerner
On July 22, 2014, 1:44 p.m., Miloslav Trmac wrote:
src/rolekit/server/rolebase.py, line 491 http://reviewboard-fedoraserver.rhcloud.com/r/27/diff/1/?file=103#file103line491
Doesn’t do anything
Dropped it
- Thomas
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/#review76 -----------------------------------------------------------
On July 22, 2014, 10:24 a.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/
(Updated July 22, 2014, 10:24 a.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
RoleBase: Write out error state changes, apply_values fails into error state
Diffs
src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/27/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/ -----------------------------------------------------------
(Updated July 22, 2014, 2:28 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description -------
RoleBase: Write out error state changes, apply_values fails into error state
Diffs (updated) -----
src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/27/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/#review91 -----------------------------------------------------------
Ship it!
Ship It!
- Miloslav Trmac
On Čec. 22, 2014, 4:28 odp., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/
(Updated Čec. 22, 2014, 4:28 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
RoleBase: Write out error state changes, apply_values fails into error state
Diffs
src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/27/diff/
Testing
Thanks,
Thomas Woerner
On July 22, 2014, 2:32 p.m., Miloslav Trmac wrote:
Ship It!
Pushed: https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=42deff4a899d50ac170...
- Thomas
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/#review91 -----------------------------------------------------------
On July 22, 2014, 6:57 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/
(Updated July 22, 2014, 6:57 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
RoleBase: Write out error state changes, apply_values fails into error state
Diffs
src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/27/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/27/ -----------------------------------------------------------
(Updated July 22, 2014, 6:57 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description -------
RoleBase: Write out error state changes, apply_values fails into error state
Diffs -----
src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/27/diff/
Testing -------
Thanks,
Thomas Woerner
rolekit-commits@lists.fedorahosted.org