----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/69/#review257 -----------------------------------------------------------
The patch looks sane to me by inspection, but I can't apply it on the current master branch. Could you please rebase it atop the domain controller patches (since these will likely all land at the same time).
- Stephen Gallagher
On Aug. 18, 2014, 3:02 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/69/
(Updated Aug. 18, 2014, 3:02 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
installFirewall uses the firewall _settings from the role: firewall and firewall_zones and stores the applied settings in _settings per zone and also for the runtime and permanant firewalld environment.
uninstallFirewall uses the fw_changes _setting from the role and removed them from the zones in runtime and permanent firewalld environment, then clears fw_changes and savet it to _settings again.
updateFirewall calls uninstallFirewall and then installFirewall
_check_property now checks ports to be valid.
Diffs
src/rolekit/server/rolebase.py 783804e3f8529232b1c0327de4d87130aaca119d
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/69/diff/
Testing
Thanks,
Thomas Woerner