----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/ -----------------------------------------------------------
(Updated Aug. 31, 2015, 3:37 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Changes -------
Rebased atop the current master branch.
Adds checking for duplicate instance names when passed explicitly.
Fixes whitespace errors.
Bugs: 1 http://github.com/libre-server/rolekit/issues#issue/1
Repository: rolekit
Description -------
We want to be able to support configuring role deployments during automated system setup (such as Anaconda kickstart for Fedora and Red Hat Enterprise Linux systems). With this patch, we add a --next-boot argument to 'rolectl deploy'. This will cause a one- time systemd service unit to be created and configured to run at the first boot.
This service unit will execute the real 'rolectl deploy' after the network is online and will process the role deployment, then delete the temporary files. These files will not be deleted in the event of an error.
Fixes https://github.com/libre-server/rolekit/issues/1
Diffs (updated) -----
config/Makefile.am 480f74f450bb2c6397848e20e3973be806123302 doc/xml/rolectl.xml c1e18b17e458a95d80f6a91a4059ac5a8a12c63a rolekit.spec 6bb09a3c58fb57fd9265c2de5b29f13569fde120 shell-completion/bash/rolectl cc9b329059e5b8d6f719537e9cab97a599281ab6 src/Makefile.am bbcdf37b417416fa0a5eeeb800a81417f3b81380 src/rolectl 466d93a000fd7ccfe2786f536e69a23e65b916e3 src/rolekit/config/__init__.py.in d9295f37061576fe697402206e18342e0f0a22be src/rolekit/rolectl/__init__.py PRE-CREATION src/rolekit/server/io/rolesettings.py e04896c826b962f71c4552a95656c93c7f2049f9 src/rolekit/server/rolebase.py 7547decb545d30408b80d05784ecd7084462365e
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/179/diff/
Testing -------
Deployed the memcache role with --next-boot. Tested it by doing 'systemctl start pendingrole-memcache-name.service'
It has not been tested with an actual kickstart yet; I am waiting for Alpha RC1 to arrive and will test it with that.
Thanks,
Stephen Gallagher