----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/5/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description -------
a = undefined_variable_name is way too obvious for static analysis tools to detect; if we want to raise an exception, use something rarer.
This doesn’t change behavior of the test code; the log in /tmp/log handles both NameError and ZeroDivisionError in the same way.
Eventually, we might end up just with an explicit raise SomeExceptionType but that’s a less realistic test code, so let’s not do it just now.
Diffs -----
src/rolekit/logger.py 9ad2464b00daa748e87cd137b7dade2d160c9313
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/5/diff/
Testing -------
Thanks,
Miloslav Trma?