----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/#review1 -----------------------------------------------------------
config/roles/databaseserver/role.py http://reviewboard-fedoraserver.rhcloud.com/r/2/#comment1
backup_path was in the testrole by accident before. The methods to handle backup_path and also the property is disabled at the moment. Should it just be enabled?
- Thomas Woerner
On July 14, 2014, 11:42 a.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/
(Updated July 14, 2014, 11:42 a.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Add placeholders for Domain Controller and Database roles
Diffs
config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c config/roles/databaseserver/role.py PRE-CREATION config/roles/domaincontroller/role.py PRE-CREATION
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/
Testing
Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.
Thanks,
Stephen Gallagher