On July 11, 2014, 4:51 p.m., Stephen Gallagher wrote:
Ship It!
Pushed: https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=df3350b49920ac760e1...
- Thomas
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://fedorahosted.org/reviewboard/r/307/#review496 -----------------------------------------------------------
On July 11, 2014, 4:05 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: https://fedorahosted.org/reviewboard/r/307/
(Updated July 11, 2014, 4:05 p.m.)
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
- currently limited to one instance per role, see MAX_INSTANCES in config/
- new class _DEFAULTS in RoleBase
- New src/rolekit/server/dbusrole.py for presenting the role in D-Bus with DEFAULTS property, getInstances, getNamedInstance and deploy methods and InstanceAdded and InstanceRemoved signals
- roled: Use of new src/rolekit/server/dbusrole.DBusRole, new methods getAllRoleInstances and getAllRoleInstancesByState, removed getRolesByState (state only in an instance)
- Basic implementation of src/rolekit/server/rolebase.RoleBase deploy and decommission methods, new StateChanged signal
Diffs
src/rolekit/server/roled.py 9682988dbdf62e9331cb5b0d997abe0db417d9a6 src/rolekit/server/rolebase.py acf58ff8222b8ffc68074dfac38635b815e5a1f7 src/rolekit/server/dbusrole.py PRE-CREATION src/Makefile.am 30b4a8ebccdaff4994c339925be4f97674a0d959
Diff: https://fedorahosted.org/reviewboard/r/307/diff/
Testing
Thanks,
Thomas Woerner