----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/18/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
This patch passes two callbacks, reply_handler and error_handler into the deploy() methods. We can pass these handlers down into asynchronous functions to allow us to avoid blocking on long- waiting routines.
This patch prepares the system for async operation but the call to do_deploy() in the rolebase is still synchronous.
Diffs -----
src/rolekit/server/dbusrole.py 6cef7cfeba6a7bbe396601c7ab31fe034757bc6a src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/18/diff/
Testing -------
I used d-feet to test the deploy() method on the testrole. It behaves as it used to.
Thanks,
Stephen Gallagher