----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/203/#review508 -----------------------------------------------------------
Ship it!
config/roles/domaincontroller/role.py (lines 133 - 138) http://reviewboard-fedoraserver.rhcloud.com/r/203/#comment300
I know this seems super-pedantic, but why not compile the regex once on the class level (if we want to optimize this point ;).
config/roles/domaincontroller/role.py (line 329) http://reviewboard-fedoraserver.rhcloud.com/r/203/#comment301
Some day I'll replace all old style string formatting with new-style calls to `.format()`, I swear. ;)
- Nils Philippsen
On Sept. 2, 2015, 5:37 nachm., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/203/
(Updated Sept. 2, 2015, 5:37 nachm.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Bugs: 43 http://github.com/libre-server/rolekit/issues#issue/43
Repository: rolekit
Description
This patch changes the default behavior of the domain controller role. After discussions with UXD experts, it was determined that the domain should never be auto-detected from the environment, since it is very difficult to change later. It should always come from some user action.
This patch changes the default domain to use the role instance name for the domain name, as long as the instance name contains valid characters. It also changes the behavior of the host_name option to set the hostname to dc-<16 characters> if it is currently set to localhost.
Fixes https://github.com/libre-server/rolekit/issues/43
Diffs
doc/xml/rolekit.roles.domaincontroller.xml 2416c889ba0035dc6247b2eb209dbe13eb3b9708 config/roles/domaincontroller/role.py 62d2bc64d6efb9c2b7e254c8d61c612f05e4c4be
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/203/diff/
Testing
Deployed multiple domain controllers with varying initial hostnames.
Thanks,
Stephen Gallagher