modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/test/i18n/TestRemoteServiceStatisticsView.java
| 13 ++++++----
1 file changed, 8 insertions(+), 5 deletions(-)
New commits:
commit b81b8420079b94e99e7a2a4159f62717353d80f4
Author: John Mazzitelli <mazz(a)redhat.com>
Date: Mon Feb 28 10:44:01 2011 -0500
I guess it would be good if I put the code in the correct close handler.
this now correctly cancels the timer when you close the stats window
diff --git
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/test/i18n/TestRemoteServiceStatisticsView.java
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/test/i18n/TestRemoteServiceStatisticsView.java
index 9bebe99..5024c59 100644
---
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/test/i18n/TestRemoteServiceStatisticsView.java
+++
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/test/i18n/TestRemoteServiceStatisticsView.java
@@ -284,8 +284,6 @@ public class TestRemoteServiceStatisticsView extends Table {
addCloseClickHandler(new CloseClickHandler() {
@Override
public void onCloseClick(CloseClientEvent event) {
- refreshTimer.cancel();
- refreshOnPageChange = false;
markForDestroy();
}
});
@@ -298,6 +296,11 @@ public class TestRemoteServiceStatisticsView extends Table {
public StatisticsWindow(String locatorId) {
super(locatorId);
+
+ final TestRemoteServiceStatisticsView view;
+ view = new
TestRemoteServiceStatisticsView(extendLocatorId("StatsViewInWin"));
+ view.window = this;
+
setTitle(TABLE_TITLE);
setShowMinimizeButton(true);
setShowMaximizeButton(true);
@@ -312,13 +315,13 @@ public class TestRemoteServiceStatisticsView extends Table {
addCloseClickHandler(new CloseClickHandler() {
@Override
public void onCloseClick(CloseClientEvent event) {
+ view.refreshTimer.cancel();
+ view.refreshOnPageChange = false;
+ view.markForDestroy();
markForDestroy();
}
});
- TestRemoteServiceStatisticsView view;
- view = new
TestRemoteServiceStatisticsView(extendLocatorId("StatsViewInWin"));
- view.window = this;
addItem(view);
final String origColor = getBodyColor();
Show replies by date