patrikp opened a new pull-request against the project: `pungi-fedora` that you are following: `` [WIP] Fixes releng#11358 ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1157
kparal commented on the pull-request: `Fixes releng#11358` that you are following: `` I find it surprising that `FEDORA_VERSION` is defined *after* this line. Are you sure this is going to work? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1157
sumantrom commented on the pull-request: `[WIP] Fixes releng#11358` that you are following: `` I have the same question. Declaring FEDORA_VERSION is weird too :\ ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1157
humaton commented on the pull-request: `[WIP] Fixes releng#11358` that you are following: `` About this variable, we don't want to manually update the script with each release. The way it is executed is ``` ./release-candidate.sh Beta-1.1 ``` or ``` ./release-candidate.sh RC-1.1 ``` you can extract the version number from that with something similar to ``` cut -d "_" -f 1 <<< $LABEL``` ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1157
humaton commented on the pull-request: `[WIP] Fixes releng#11358` that you are following: `` that echo is probably leftover after debugging, please remove it. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1157
adamwill commented on the pull-request: `[WIP] Fixes releng#11358` that you are following: `` this reads weird without curly braces, and isn't it duplicating the version number, since that's already in the label? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1157
humaton commented on the pull-request: `[WIP] Fixes releng#11358` that you are following: `` A few of the new artifact dirs are missing here Sericea maybe more ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1157
humaton commented on the pull-request: `Fixes releng#11358` that you are following: `` huh why is the || exit sudenly after each popd and pushd? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1157
humaton commented on the pull-request: `Fixes releng#11358` that you are following: `` this was commented out in the original script. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1157
humaton commented on the pull-request: `Fixes releng#11358` that you are following: `` Look good. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1157
humaton merged a pull-request against the project: `pungi-fedora` that you are following.
Merged pull-request:
`` Fixes releng#11358 ``
rel-eng@lists.fedoraproject.org