sgallagh commented on the pull-request: `Update pki stream name in variants-modular.xml` that you are following: `` @karsten This change makes me VERY nervous; the diff between the master and 10.4 branches is very significant: ```diff diff --git a/pki.yaml b/pki.yaml index 3bf9157..a81167a 100644 --- a/pki.yaml +++ b/pki.yaml @@ -6,18 +6,20 @@ data: license: module: - MIT dependencies: buildrequires: - bootstrap: master - tomcat: master + bootstrap: f27 requires: - platform: master - java: master - tomcat: master - resteasy: master - apache-commons: master + platform: f27 + java: 8 + tomcat: 8.0 + resteasy: 3.0 + apache-commons: f27 + python2-ecosystem: f27 + maven: f27 + networking-base: f27 references: community: https://docs.pagure.org/modularity/ documentation: https://github.com/modularity-modules/pki tracker: https://github.com/modularity-modules/pki api: @@ -26,15 +28,14 @@ data: - pki-base-java - pki-ca - pki-kra - pki-server - pki-tools - - pylint + - python2-ldap - python3-nss - python3-pluggy - python3-pyldap - - python3-tox - svrcore - svrcore-devel profiles: default: description: A generated profile based on top-lvl package list. @@ -43,172 +44,59 @@ data: - pki-base-java - pki-ca - pki-kra - pki-server - pki-tools - - pylint + - python2-ldap - python3-nss - python3-pluggy - python3-pyldap - - python3-tox - svrcore - svrcore-devel + filter: + rpms: + - python-pluggy + - python3-pluggy + - python2-tox + - python3-tox + - tomcatjss components: rpms: - python-pluggy: + python-nss: rationale: Generated. ref: f27 + buildorder: -5 + python-pluggy: + rationale: Generated. + ref: master buildorder: -10 python-tox: rationale: Generated. - ref: f27 + ref: master buildorder: -10 - pylint: - rationale: Generated. - ref: f27 - buildorder: -5 - python-nss: - rationale: Generated. - ref: f27 - buildorder: -5 python-pyldap: rationale: Generated. ref: master buildorder: -5 - svrcore: - rationale: Generated. - ref: f27 - buildorder: -5 nuxwdog: rationale: Generated. ref: f27 buildorder: -3 python-ldap: rationale: Generated. ref: f27 buildorder: -3 - jakarta-commons-httpclient: - rationale: Generated. - ref: f27 - javassist: + jss: rationale: Generated. ref: f27 + buildorder: -3 ldapjdk: rationale: Generated.. ref: f27 - net-tools: - rationale: Generated. + buildorder: -3 + tomcatjss: + rationale: Generated.. ref: f27 + buildorder: -3 pki-core: rationale: Generated. ref: f27 - pyOpenSSL: - rationale: Generated. - ref: f27 - pytest: - rationale: Generated. - ref: master - python-asn1crypto: - rationale: Generated. - ref: f27 - python-astroid: - rationale: Generated. - ref: f27 - python-backports: - rationale: Generated. - ref: f27 - python-backports-ssl_match_hostname: - rationale: Generated. - ref: f27 - python-beautifulsoup4: - rationale: Generated. - ref: master - python-cffi: - rationale: Generated. - ref: f27 - python-chardet: - rationale: Generated. - ref: f27 - python-cryptography: - rationale: Generated. - ref: f27 - python-cssselect: - rationale: Generated. - ref: f27 - python-enum34: - rationale: Generated. - ref: f27 - python-html5lib: - rationale: Generated. - ref: f27 - python-idna: - rationale: Generated. - ref: f27 - python-ipaddress: - rationale: Generated. - ref: f27 - python-isort: - rationale: Generated. - ref: f27 - python-lazy-object-proxy: - rationale: Generated. - ref: f27 - python-lxml: - rationale: Generated. - ref: f27 - python-mccabe: - rationale: Generated. - ref: f27 - python-ply: - rationale: Generated. - ref: f27 - python-py: - rationale: Generated. - ref: f27 - python-pyasn1: - rationale: Generated. - ref: f27 - python-pycparser: - rationale: Generated. - ref: f27 - python-pysocks: - rationale: Generated. - ref: f27 - python-pytest-runner: - rationale: Generated. - ref: master - python-requests: - rationale: Generated. - ref: f27 - python-rpm-generators: - rationale: Generated. - ref: f27 - python-urllib3: - rationale: Generated. - ref: f27 - python-virtualenv: - rationale: Generated. - ref: f27 - python-webencodings: - rationale: Generated. - ref: f27 - python-wrapt: - rationale: Generated. - ref: f27 - slf4j: - rationale: Generated. - ref: f27 - velocity: - rationale: Generated. - ref: f27 - xalan-j2: - rationale: Generated. - ref: f27 - xerces-j2: - rationale: Generated. - ref: f27 - xml-commons-apis: - rationale: Generated. - ref: f27 - xml-commons-resolver: - rationale: Generated. - ref: f27 ```

Considering that this is a dependency for FreeIPA, I'm nervous about making such a large change just before Final Freeze. Can you justify all the changes, please? Or prove that you've tested this with FreeIPA? ``

To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/470